mirror of
https://github.com/golang/go
synced 2024-09-04 23:44:16 +00:00
cmd/compile: evaluate zero-sized values converted to interfaces
CL 35562 substituted zerobase for the pointer for interfaces containing zero-sized values. However, it failed to evaluate the zero-sized value expression for side-effects. Fix that. The other similar interface value optimizations are not affected, because they all actually use the value one way or another. Fixes #19246 Change-Id: I1168a99561477c63c29751d5cd04cf81b5ea509d Reviewed-on: https://go-review.googlesource.com/37395 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Cherry Zhang <cherryyz@google.com>
This commit is contained in:
parent
f8ae30c4a2
commit
d9270ecb3a
|
@ -882,6 +882,7 @@ opswitch:
|
|||
switch {
|
||||
case n.Left.Type.Size() == 0:
|
||||
// n.Left is zero-sized. Use zerobase.
|
||||
cheapexpr(n.Left, init) // Evaluate n.Left for side-effects. See issue 19246.
|
||||
value = zerobase
|
||||
case n.Left.Type.IsBoolean() || (n.Left.Type.Size() == 1 && n.Left.Type.IsInteger()):
|
||||
// n.Left is a bool/byte. Use staticbytes[n.Left].
|
||||
|
|
28
test/fixedbugs/issue19246.go
Normal file
28
test/fixedbugs/issue19246.go
Normal file
|
@ -0,0 +1,28 @@
|
|||
// run
|
||||
|
||||
// Copyright 2017 The Go Authors. All rights reserved.
|
||||
// Use of this source code is governed by a BSD-style
|
||||
// license that can be found in the LICENSE file.
|
||||
|
||||
// Issue 19246: Failed to evaluate some zero-sized values
|
||||
// when converting them to interfaces.
|
||||
|
||||
package main
|
||||
|
||||
import "os"
|
||||
|
||||
type B struct{}
|
||||
|
||||
//go:noinline
|
||||
func f(i interface{}) {}
|
||||
|
||||
func main() {
|
||||
defer func() {
|
||||
if recover() == nil {
|
||||
println("expected nil pointer dereference panic")
|
||||
os.Exit(1)
|
||||
}
|
||||
}()
|
||||
var b *B
|
||||
f(*b)
|
||||
}
|
Loading…
Reference in a new issue