languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-05 16:04:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

runtime/trace: skip tests if parsing fails with timestamp error

Browse source 
already skips tests in case of the timestamp error, eg. #97757

Change-Id: Ia696e83cba2e3ed50181a8100b964847092a7365
GitHub-Last-Rev: 8e5f607e14
GitHub-Pull-Request: golang/go#55918
Reviewed-on: https://go-review.googlesource.com/c/go/+/435855
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Joel Sing <joel@sing.id.au>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
This commit is contained in:
doujiang24 2022-09-29 07:29:51 +00:00 committed by Joel Sing
parent 9faf6b7929
commit d7dbe0111e
2 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/runtime/crash_cgo_test.go
View file

@ -730,7 +730,10 @@ func TestCgoTraceParser(t *testing.T) {
}
output := runTestProg(t, "testprogcgo", "CgoTraceParser")
want := "OK\n"
if output != want {
ErrTimeOrder := "ErrTimeOrder\n"
if output == ErrTimeOrder {
t.Skipf("skipping due to golang.org/issue/16755: %v", output)
} else if output != want {
t.Fatalf("want %s, got %s\n", want, output)
}
}
@ -743,7 +746,10 @@ func TestCgoTraceParserWithOneProc(t *testing.T) {
}
output := runTestProg(t, "testprogcgo", "CgoTraceParser", "GOMAXPROCS=1")
want := "OK\n"
if output != want {
ErrTimeOrder := "ErrTimeOrder\n"
if output == ErrTimeOrder {
t.Skipf("skipping due to golang.org/issue/16755: %v", output)
} else if output != want {
t.Fatalf("GOMAXPROCS=1, want %s, got %s\n", want, output)
}
}

4
src/runtime/testdata/testprogcgo/issue29707.go vendored
View file

@ -50,7 +50,9 @@ func CgoTraceParser() {
trace.Stop()
_, err := traceparser.Parse(buf, "")
if err != nil {
if err == traceparser.ErrTimeOrder {
fmt.Println("ErrTimeOrder")
} else if err != nil {
fmt.Println("Parse error: ", err)
} else {
fmt.Println("OK")