languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-10-14 11:53:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

image/png: update palette out-of-bounds comment.

Browse source 
R=r
CC=golang-dev
https://golang.org/cl/6817070
This commit is contained in:
Nigel Tao 2012-11-02 17:20:19 +11:00
parent 002103f51c
commit d659633aff
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/pkg/image/png/reader.go
View file

@ -198,10 +198,11 @@ func (d *decoder) parsePLTE(length uint32) error {
d.palette[i] = color.RGBA{d.tmp[3*i+0], d.tmp[3*i+1], d.tmp[3*i+2], 0xff} d.palette[i] = color.RGBA{d.tmp[3*i+0], d.tmp[3*i+1], d.tmp[3*i+2], 0xff}
} }
for i := np; i < 256; i++ { for i := np; i < 256; i++ {
// Initialize the rest of the palette to opaque black. The spec isn't // Initialize the rest of the palette to opaque black. The spec (section
// clear whether palette index values outside of those defined by the PLTE // 11.2.3) says that "any out-of-range pixel value found in the image data
// chunk is an error: libpng 1.5.13 falls back to opaque black, the // is an error", but some real-world PNG files have out-of-range pixel
// same as we do here, ImageMagick 6.5.7 returns an error. // values. We fall back to opaque black, the same as libpng 1.5.13;
// ImageMagick 6.5.7 returns an error.
d.palette[i] = color.RGBA{0x00, 0x00, 0x00, 0xff} d.palette[i] = color.RGBA{0x00, 0x00, 0x00, 0xff}
} }
d.palette = d.palette[:np] d.palette = d.palette[:np]