languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-05 18:36:08 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: give informative error instead of "stupid shift"

Browse source 
Fixes #13940.

Change-Id: I00fe377c949e5be4cbc035f6ca18e547e326bfba
Reviewed-on: https://go-review.googlesource.com/19856
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Robert Griesemer 2016-02-23 13:35:12 -08:00
parent ef3c45adfc
commit d1cc7f70cd
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/cmd/compile/internal/gc/mparith2.go
View file

@ -217,7 +217,11 @@ func mplshfixfix(a, b *Mpint) {
s := Mpgetfix(b)
if s < 0 || s >= Mpprec {
Yyerror("stupid shift: %d", s)
msg := "shift count too large"
if s < 0 {
msg = "invalid negative shift count"
}
Yyerror("%s: %d", msg, s)
Mpmovecfix(a, 0)
return
}
@ -236,7 +240,7 @@ func mprshfixfix(a, b *Mpint) {
s := Mpgetfix(b)
if s < 0 {
Yyerror("stupid shift: %d", s)
Yyerror("invalid negative shift count: %d", s)
if a.Val.Sign() < 0 {
Mpmovecfix(a, -1)
} else {

2
test/fixedbugs/bug108.go
View file

@ -6,6 +6,6 @@
package main
func f() {
v := 1 << 1025; // ERROR "overflow|stupid shift"
v := 1 << 1025; // ERROR "overflow|shift count too large"
_ = v
}