mirror of
https://github.com/golang/go
synced 2024-09-05 16:04:50 +00:00
cmd/compile: reject large argument areas
Extend stack frame limit of 1GB to include large argument/return areas. Argument/return areas are part of the parent frame, not the frame itself, so they need to be handled separately. Fixes #25507. Change-Id: I309298a58faee3e7c1dac80bd2f1166c82460087 Reviewed-on: https://go-review.googlesource.com/115036 Run-TryBot: Keith Randall <khr@golang.org> Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
parent
ab922e1012
commit
d15d055054
|
@ -257,7 +257,8 @@ const maxStackSize = 1 << 30
|
|||
// worker indicates which of the backend workers is doing the processing.
|
||||
func compileSSA(fn *Node, worker int) {
|
||||
f := buildssa(fn, worker)
|
||||
if f.Frontend().(*ssafn).stksize >= maxStackSize {
|
||||
// Note: check arg size to fix issue 25507.
|
||||
if f.Frontend().(*ssafn).stksize >= maxStackSize || fn.Type.ArgWidth() >= maxStackSize {
|
||||
largeStackFramesMu.Lock()
|
||||
largeStackFrames = append(largeStackFrames, fn.Pos)
|
||||
largeStackFramesMu.Unlock()
|
||||
|
|
|
@ -174,6 +174,7 @@ func TestStdFixed(t *testing.T) {
|
|||
"issue20529.go", // go/types does not have constraints on stack size
|
||||
"issue22200.go", // go/types does not have constraints on stack size
|
||||
"issue22200b.go", // go/types does not have constraints on stack size
|
||||
"issue25507.go", // go/types does not have constraints on stack size
|
||||
)
|
||||
}
|
||||
|
||||
|
|
29
test/fixedbugs/issue25507.go
Normal file
29
test/fixedbugs/issue25507.go
Normal file
|
@ -0,0 +1,29 @@
|
|||
// errorcheck
|
||||
|
||||
// Copyright 2018 The Go Authors. All rights reserved.
|
||||
// Use of this source code is governed by a BSD-style
|
||||
// license that can be found in the LICENSE file.
|
||||
|
||||
// We have a limit of 1GB for stack frames.
|
||||
// Test that we extend that limit to include large argument/return areas.
|
||||
// Argument/return areas are part of the parent frame, not the frame itself,
|
||||
// so they need to be handled separately.
|
||||
|
||||
package main
|
||||
|
||||
// >1GB to trigger failure, <2GB to work on 32-bit platforms.
|
||||
type large struct {
|
||||
b [1500000000]byte
|
||||
}
|
||||
|
||||
func (x large) f1() int { // ERROR "stack frame too large"
|
||||
return 5
|
||||
}
|
||||
|
||||
func f2(x large) int { // ERROR "stack frame too large"
|
||||
return 5
|
||||
}
|
||||
|
||||
func f3() (x large, i int) { // ERROR "stack frame too large"
|
||||
return
|
||||
}
|
Loading…
Reference in a new issue