mirror of
https://github.com/golang/go
synced 2024-10-04 15:09:59 +00:00
cmd/compile: reject not-in-heap types as type arguments
After running the types2 type checker, walk info.Instances to reject any not-in-heap type arguments. This is feasible to check using the types2 API now, thanks to #46731. Fixes #54765. Change-Id: Idd2acc124d102d5a76f128f13c21a6e593b6790b Reviewed-on: https://go-review.googlesource.com/c/go/+/427235 Reviewed-by: Keith Randall <khr@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Keith Randall <khr@google.com>
This commit is contained in:
parent
e4b624eae5
commit
ca634fa2c5
|
@ -256,3 +256,28 @@ func isTypeParam(t types2.Type) bool {
|
||||||
_, ok := t.(*types2.TypeParam)
|
_, ok := t.(*types2.TypeParam)
|
||||||
return ok
|
return ok
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// isNotInHeap reports whether typ is or contains an element of type
|
||||||
|
// runtime/internal/sys.NotInHeap.
|
||||||
|
func isNotInHeap(typ types2.Type) bool {
|
||||||
|
if named, ok := typ.(*types2.Named); ok {
|
||||||
|
if obj := named.Obj(); obj.Name() == "nih" && obj.Pkg().Path() == "runtime/internal/sys" {
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
typ = named.Underlying()
|
||||||
|
}
|
||||||
|
|
||||||
|
switch typ := typ.(type) {
|
||||||
|
case *types2.Array:
|
||||||
|
return isNotInHeap(typ.Elem())
|
||||||
|
case *types2.Struct:
|
||||||
|
for i := 0; i < typ.NumFields(); i++ {
|
||||||
|
if isNotInHeap(typ.Field(i).Type()) {
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return false
|
||||||
|
default:
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
|
@ -6,6 +6,7 @@ package noder
|
||||||
|
|
||||||
import (
|
import (
|
||||||
"fmt"
|
"fmt"
|
||||||
|
"sort"
|
||||||
|
|
||||||
"cmd/compile/internal/base"
|
"cmd/compile/internal/base"
|
||||||
"cmd/compile/internal/dwarfgen"
|
"cmd/compile/internal/dwarfgen"
|
||||||
|
@ -63,6 +64,31 @@ func checkFiles(noders []*noder) (posMap, *types2.Package, *types2.Info) {
|
||||||
|
|
||||||
pkg, err := conf.Check(base.Ctxt.Pkgpath, files, info)
|
pkg, err := conf.Check(base.Ctxt.Pkgpath, files, info)
|
||||||
|
|
||||||
|
// Implementation restriction: we don't allow not-in-heap types to
|
||||||
|
// be used as type arguments (#54765).
|
||||||
|
{
|
||||||
|
type nihTarg struct {
|
||||||
|
pos src.XPos
|
||||||
|
typ types2.Type
|
||||||
|
}
|
||||||
|
var nihTargs []nihTarg
|
||||||
|
|
||||||
|
for name, inst := range info.Instances {
|
||||||
|
for i := 0; i < inst.TypeArgs.Len(); i++ {
|
||||||
|
if targ := inst.TypeArgs.At(i); isNotInHeap(targ) {
|
||||||
|
nihTargs = append(nihTargs, nihTarg{m.makeXPos(name.Pos()), targ})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
sort.Slice(nihTargs, func(i, j int) bool {
|
||||||
|
ti, tj := nihTargs[i], nihTargs[j]
|
||||||
|
return ti.pos.Before(tj.pos)
|
||||||
|
})
|
||||||
|
for _, targ := range nihTargs {
|
||||||
|
base.ErrorfAt(targ.pos, "cannot use incomplete (or unallocatable) type as a type argument: %v", targ.typ)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
base.ExitIfErrors()
|
base.ExitIfErrors()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
base.FatalfAt(src.NoXPos, "conf.Check error: %v", err)
|
base.FatalfAt(src.NoXPos, "conf.Check error: %v", err)
|
||||||
|
|
28
test/typeparam/issue54765.go
Normal file
28
test/typeparam/issue54765.go
Normal file
|
@ -0,0 +1,28 @@
|
||||||
|
// errorcheck
|
||||||
|
|
||||||
|
// Copyright 2022 The Go Authors. All rights reserved.
|
||||||
|
// Use of this source code is governed by a BSD-style
|
||||||
|
// license that can be found in the LICENSE file.
|
||||||
|
|
||||||
|
// Test that not-in-heap types cannot be used as type
|
||||||
|
// arguments. (pointer-to-nih types are okay though.)
|
||||||
|
|
||||||
|
//go:build cgo
|
||||||
|
// +build cgo
|
||||||
|
|
||||||
|
package p
|
||||||
|
|
||||||
|
import (
|
||||||
|
"runtime/cgo"
|
||||||
|
"sync/atomic"
|
||||||
|
)
|
||||||
|
|
||||||
|
var _ atomic.Pointer[cgo.Incomplete] // ERROR "cannot use incomplete \(or unallocatable\) type as a type argument: runtime/cgo\.Incomplete"
|
||||||
|
var _ atomic.Pointer[*cgo.Incomplete] // ok
|
||||||
|
|
||||||
|
func implicit(ptr *cgo.Incomplete) {
|
||||||
|
g(ptr) // ERROR "cannot use incomplete \(or unallocatable\) type as a type argument: runtime/cgo\.Incomplete"
|
||||||
|
g(&ptr) // ok
|
||||||
|
}
|
||||||
|
|
||||||
|
func g[T any](_ *T) {}
|
Loading…
Reference in a new issue