languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-15 14:10:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/internal/gc: type of str[i] is byte, not uint8

Browse source 
Fixes #8745.

Change-Id: Id0641e3c0f259812b41ed871e83c68740feb2b19
Reviewed-on: https://go-review.googlesource.com/10261
Reviewed-by: Austin Clements <austin@google.com>
This commit is contained in:
Russ Cox 2015-05-19 14:00:27 -04:00
parent 913db7685e
commit c735064cde
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/cmd/internal/gc/typecheck.go
View file

@ -1027,7 +1027,7 @@ OpSwitch:
case TSTRING, TARRAY:
indexlit(&n.Right)
if t.Etype == TSTRING {
n.Type = Types[TUINT8]
n.Type = bytetype
} else {
n.Type = t.Type
}

13
test/fixedbugs/issue8745.go Normal file
View file

@ -0,0 +1,13 @@
// errorcheck
// Copyright 2015 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// Check that the error says s[2] is a byte, not a uint8.
package p
func f(s string) {
var _ float64 = s[2] // ERROR "cannot use.*type byte.*as type float64"
}