languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-10-16 04:43:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/pprof: fix exception when file or path contains colon

Browse source 
Fixes #63924

Change-Id: I4ea17979faaca04eb6b046abffca2dd77397e0cb
Reviewed-on: https://go-review.googlesource.com/c/go/+/539595
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Run-TryBot: shuang cui <imcusg@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
This commit is contained in:
cui fliter 2023-11-03 15:03:12 +08:00 committed by Cherry Mui
parent 959e65c41c
commit c5698e3155
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/cmd/pprof/pprof.go
View file

@ -45,6 +45,16 @@ type fetcher struct {
}
func (f *fetcher) Fetch(src string, duration, timeout time.Duration) (*profile.Profile, string, error) {
// Firstly, determine if the src is an existing file on the disk.
// If it is a file, let regular pprof open it.
// If it is not a file, when the src contains `:`
// (e.g. mem_2023-11-02_03:55:24 or abc:123/mem_2023-11-02_03:55:24),
// url.Parse will recognize it as a link and ultimately report an error,
// similar to `abc:123/mem_2023-11-02_03:55:24:
// Get "http://abc:123/mem_2023-11-02_03:55:24": dial tcp: lookup abc: no such host`
if _, openErr := os.Stat(src); openErr == nil {
return nil, "", nil
}
sourceURL, timeout := adjustURL(src, duration, timeout)
if sourceURL == "" {
// Could not recognize URL, let regular pprof attempt to fetch the profile (eg. from a file)