languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-10-14 20:05:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/internal/testdir: pass if GOEXPERIMENT=cgocheck2 is set

Browse source 
Some testdir tests fail if GOEXPERIMENT=cgocheck2 is set. Fix this by
skipping these tests.

Change-Id: I58d4ef0cceb86bcf93220b4a44de9b9dc4879b16
Reviewed-on: https://go-review.googlesource.com/c/go/+/499675
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
This commit is contained in:
Austin Clements 2023-05-31 12:32:29 -04:00
parent 563556ccc7
commit c2e0bf0abf
3 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
test/codegen/structs.go
View file

@ -1,5 +1,8 @@
// asmcheck
//go:build !goexperiment.cgocheck2
// +build !goexperiment.cgocheck2
// Copyright 2018 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

3
test/fixedbugs/issue15747.go
View file

@ -1,5 +1,8 @@
// errorcheck -0 -live
//go:build !goexperiment.cgocheck2
// +build !goexperiment.cgocheck2
// Copyright 2016 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

5
test/fixedbugs/issue20250.go
View file

@ -1,5 +1,8 @@
// errorcheck -0 -live -l
//go:build !goexperiment.cgocheck2
// +build !goexperiment.cgocheck2
// Copyright 2017 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
@ -16,7 +19,7 @@ type T struct {
func f(a T) { // ERROR "live at entry to f: a$"
var e interface{} // ERROR "stack object e interface \{\}$"
func() { // ERROR "live at entry to f.func1: &e a$"
func() { // ERROR "live at entry to f.func1: &e a$"
e = a.s // ERROR "live at call to convT: &e$" "stack object a T$"
}()
// Before the fix, both a and e were live at the previous line.