From 104445e3140f4468839db49a25cb0182f7923174 Mon Sep 17 00:00:00 2001
From: Russ Cox
Date: Wed, 7 Feb 2018 14:10:48 -0500
Subject: [PATCH 1/7] doc: document Go 1.9.4 and Go 1.8.7
Change-Id: I50928e7747f43858fc863b53cfb5b63e208d6932
Reviewed-on: https://team-review.git.corp.google.com/213447
Reviewed-by: Andrew Bonventre
---
doc/devel/release.html | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/doc/devel/release.html b/doc/devel/release.html
index 24fe583062..d82fb0c630 100644
--- a/doc/devel/release.html
+++ b/doc/devel/release.html
@@ -57,6 +57,12 @@ See the Go
1.9.3 milestone on our issue tracker for details.
+
+go1.9.4 (released 2018/02/07) includes a security fix to “go get”.
+See the Go
+1.9.4 milestone on our issue tracker for details.
+
+
go1.8 (released 2017/02/16)
@@ -114,6 +120,13 @@ See the Go
1.8.6 milestone on our issue tracker for details.
+
+go1.8.7 (released 2018/02/07) includes a security fix to “go get”.
+It contains the same fix as Go 1.9.4 and was released at the same time.
+See the Go
+1.8.7 milestone on our issue tracker for details.
+
+
go1.7 (released 2016/08/15)
From d814c2be9b6b719f9cf5ec9ff98a6c558aba23f0 Mon Sep 17 00:00:00 2001
From: Andrew Bonventre
Date: Thu, 8 Feb 2018 23:50:16 +0000
Subject: [PATCH 2/7] doc: remove Pull Request note in README.md
Since we now accept Pull Requests via GerritBot, this comment is obsolete.
Change-Id: I0de8ecff7d1f146320a52f143e65068f8adbeaa6
GitHub-Last-Rev: 01818bdf7a8361efde427a872b813f2e8510cef7
GitHub-Pull-Request: golang/go#23752
Reviewed-on: https://go-review.googlesource.com/92995
Reviewed-by: Brad Fitzpatrick
---
README.md | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/README.md b/README.md
index 57492b3fb0..bb3d895d45 100644
--- a/README.md
+++ b/README.md
@@ -36,10 +36,9 @@ Go is the work of hundreds of contributors. We appreciate your help!
To contribute, please read the contribution guidelines:
https://golang.org/doc/contribute.html
-Note that the Go project does not use GitHub pull requests, and that
-we use the issue tracker for bug reports and proposals only. See
-https://golang.org/wiki/Questions for a list of places to ask
-questions about the Go language.
+Note that the Go project uses the issue tracker for bug reports and
+proposals only. See https://golang.org/wiki/Questions for a list of
+places to ask questions about the Go language.
[rf]: https://reneefrench.blogspot.com/
[cc3-by]: https://creativecommons.org/licenses/by/3.0/
From c6e7330ebd901aa9b9ac8ed4223fe0a0d71b1b13 Mon Sep 17 00:00:00 2001
From: Andrew Bonventre
Date: Thu, 8 Feb 2018 19:29:19 -0500
Subject: [PATCH 3/7] all: remove PULL_REQUEST_TEMPLATE from .github
Update golang/go#18517
Change-Id: I76d928d5fcc5ed22beaffb86f0fa8fbf6d4ac3d7
Reviewed-on: https://go-review.googlesource.com/93035
Reviewed-by: Brad Fitzpatrick
---
.github/PULL_REQUEST_TEMPLATE | 7 -------
1 file changed, 7 deletions(-)
delete mode 100644 .github/PULL_REQUEST_TEMPLATE
diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE
deleted file mode 100644
index 00014e9b86..0000000000
--- a/.github/PULL_REQUEST_TEMPLATE
+++ /dev/null
@@ -1,7 +0,0 @@
-Please do not send pull requests to the golang/* repositories.
-
-We do, however, take contributions gladly.
-
-See https://golang.org/doc/contribute.html
-
-Thanks!
From ee59f6dff2c25b39d12b16082343a74c825b5ea1 Mon Sep 17 00:00:00 2001
From: JBD
Date: Fri, 9 Feb 2018 01:14:31 +0000
Subject: [PATCH 4/7] doc: minor wording improvement to the diagnostics guide
Change-Id: I8469fbbb934f096f04ad68c592aacdb805b6d2d4
GitHub-Last-Rev: 6d2cfcc23d0d8e6a1b6ca383dae51f0cada2e1b3
GitHub-Pull-Request: golang/go#23754
Reviewed-on: https://go-review.googlesource.com/92996
Reviewed-by: Andrew Bonventre
---
doc/diagnostics.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/diagnostics.html b/doc/diagnostics.html
index 0ed0e81b92..35aae156e8 100644
--- a/doc/diagnostics.html
+++ b/doc/diagnostics.html
@@ -222,7 +222,7 @@ an execution tracer to trace the runtime events within an interval.
Tracing enables us to:
-- Instrument and profile application latency in a Go process.
+- Instrument and analyze application latency in a Go process.
- Measure the cost of specific calls in a long chain of calls.
- Figure out the utilization and performance improvements.
Bottlenecks are not always obvious without tracing data.
From 829b64c1ead819bdf84d950581020c36f00cd02b Mon Sep 17 00:00:00 2001
From: Keith Randall
Date: Fri, 9 Feb 2018 11:21:37 -0800
Subject: [PATCH 5/7] cmd/fix: fix cast check
Need 2-result cast so we can check the result correctly.
Fixes #23762
Change-Id: Icac3a5415156fe918988f369d6022a9a29c14089
Reviewed-on: https://go-review.googlesource.com/93078
Run-TryBot: Keith Randall
Reviewed-by: Brad Fitzpatrick
Reviewed-by: Ian Lance Taylor
TryBot-Result: Gobot Gobot
---
src/cmd/fix/cftype.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/cmd/fix/cftype.go b/src/cmd/fix/cftype.go
index df1cc18f9e..b47b06682a 100644
--- a/src/cmd/fix/cftype.go
+++ b/src/cmd/fix/cftype.go
@@ -119,7 +119,7 @@ func typefix(f *ast.File, badType func(string) bool) bool {
if !ok {
return
}
- t := s.X.(*ast.SelectorExpr)
+ t, ok := s.X.(*ast.SelectorExpr)
if !ok {
return
}
From c52e27e68dca0b6d3fb9f9442cfee8efcbca557e Mon Sep 17 00:00:00 2001
From: Brad Fitzpatrick
Date: Sun, 11 Feb 2018 16:20:38 +0000
Subject: [PATCH 6/7] CONTRIBUTING: remove Pull Request bit
Also remove the "Also, please do not post patches on the issue
tracker" part, since that didn't seem to reduce the number of patches
inlined into bug reports. And now that we accept PRs, people will
probably try that first. We'll see.
Fixes #23779
Updates #18517
Change-Id: I449e0afd7292718e57d9d428494799c78296a0d2
Reviewed-on: https://go-review.googlesource.com/93335
Reviewed-by: Andrew Bonventre
---
CONTRIBUTING.md | 5 -----
1 file changed, 5 deletions(-)
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 4f2c4d4b02..7c1dd54b30 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -30,11 +30,6 @@ For change proposals, see [Proposing Changes To Go](https://github.com/golang/pr
Please read the [Contribution Guidelines](https://golang.org/doc/contribute.html) before sending patches.
-**We do not accept GitHub pull requests**
-(we use [an instance](https://go-review.googlesource.com/) of the
-[Gerrit](https://www.gerritcodereview.com/) code review system instead).
-Also, please do not post patches on the issue tracker.
-
Unless otherwise noted, the Go source files are distributed under
the BSD-style license found in the LICENSE file.
From 74b56022a1f834b3edce5c3eca0570323ac90cd7 Mon Sep 17 00:00:00 2001
From: Brad Fitzpatrick
Date: Wed, 7 Feb 2018 16:07:34 +0000
Subject: [PATCH 7/7] doc: note that x509 cert parsing rejects some more certs
now
Fixes #23711
---
doc/go1.10.html | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/doc/go1.10.html b/doc/go1.10.html
index 5885176f46..569e420d51 100644
--- a/doc/go1.10.html
+++ b/doc/go1.10.html
@@ -785,7 +785,8 @@ Parsed certificates also now report URI names and IP, email, and URI constraints
Certificate
fields
URIs
, PermittedIPRanges
, ExcludedIPRanges
,
PermittedEmailAddresses
, ExcludedEmailAddresses
,
-PermittedURIDomains
, and ExcludedURIDomains
.
+PermittedURIDomains
, and ExcludedURIDomains
. Certificates with
+invalid values for those fields are now rejected.