languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-02 13:42:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

runtime: enable race detector on openbsd/amd64

Browse source 
Now that this commit[1] has landed in LLVM the .syso file can be generated for
OpenBSD.

With the changes to src/runtime running the sample race[2] detects the data
race as expected.

Based on golang/go#39464 (https://go-review.googlesource.com/c/go/+/237057) from
Aaron Bieber <deftly@gmail.com>, however the race_openbsd_amd64.syso file has
been built on OpenBSD 6.4 and necessary changes added to race.bash.

[1] fcf6ae2f07
[2] https://golang.org/doc/articles/race_detector.html

Change-Id: Ic2479ccfa91d6b2cb4585346a11d813d96450f68
Reviewed-on: https://go-review.googlesource.com/c/go/+/275892
Trust: Joel Sing <joel@sing.id.au>
Run-TryBot: Joel Sing <joel@sing.id.au>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
This commit is contained in:
Joel Sing 2020-12-08 04:14:34 +11:00
parent a78b0e6721
commit b3b65f2176
6 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/cmd/dist/test.go vendored
View file

@ -1633,7 +1633,7 @@ func raceDetectorSupported(goos, goarch string) bool {
return goarch == "amd64" || goarch == "ppc64le" || goarch == "arm64" return goarch == "amd64" || goarch == "ppc64le" || goarch == "arm64"
case "darwin": case "darwin":
return goarch == "amd64" || goarch == "arm64" return goarch == "amd64" || goarch == "arm64"
case "freebsd", "netbsd", "windows": case "freebsd", "netbsd", "openbsd", "windows":
return goarch == "amd64" return goarch == "amd64"
default: default:
return false return false

2
src/cmd/internal/sys/supported.go
View file

@ -15,7 +15,7 @@ func RaceDetectorSupported(goos, goarch string) bool {
return goarch == "amd64" || goarch == "ppc64le" || goarch == "arm64" return goarch == "amd64" || goarch == "ppc64le" || goarch == "arm64"
case "darwin": case "darwin":
return goarch == "amd64" || goarch == "arm64" return goarch == "amd64" || goarch == "arm64"
case "freebsd", "netbsd", "windows": case "freebsd", "netbsd", "openbsd", "windows":
return goarch == "amd64" return goarch == "amd64"
default: default:
return false return false

7
src/race.bash
View file

@ -9,7 +9,7 @@
set -e set -e
function usage { function usage {
echo 'race detector is only supported on linux/amd64, linux/ppc64le, linux/arm64, freebsd/amd64, netbsd/amd64, darwin/amd64, and darwin/arm64' 1>&2 echo 'race detector is only supported on linux/amd64, linux/ppc64le, linux/arm64, freebsd/amd64, netbsd/amd64, openbsd/amd64, darwin/amd64, and darwin/arm64' 1>&2
exit 1 exit 1
} }
@ -34,6 +34,11 @@ case $(uname) in
usage usage
fi fi
;; ;;
"OpenBSD")
if [ $(uname -m) != "amd64" ]; then
usage
fi
;;
*) *)
usage usage
;; ;;

1
src/runtime/race/README
View file

@ -12,3 +12,4 @@ race_netbsd_amd64.syso built with LLVM 89f7ccea6f6488c443655880229c54db1f180153
race_windows_amd64.syso built with LLVM 89f7ccea6f6488c443655880229c54db1f180153 and Go f62d3202bf9dbb3a00ad2a2c63ff4fa4188c5d3b. race_windows_amd64.syso built with LLVM 89f7ccea6f6488c443655880229c54db1f180153 and Go f62d3202bf9dbb3a00ad2a2c63ff4fa4188c5d3b.
race_linux_arm64.syso built with LLVM 89f7ccea6f6488c443655880229c54db1f180153 and Go f62d3202bf9dbb3a00ad2a2c63ff4fa4188c5d3b. race_linux_arm64.syso built with LLVM 89f7ccea6f6488c443655880229c54db1f180153 and Go f62d3202bf9dbb3a00ad2a2c63ff4fa4188c5d3b.
race_darwin_arm64.syso built with LLVM 00da38ce2d36c07f12c287dc515d37bb7bc410e9 and Go fe70a3a0fd31441bcbb9932ecab11a6083cf2119. race_darwin_arm64.syso built with LLVM 00da38ce2d36c07f12c287dc515d37bb7bc410e9 and Go fe70a3a0fd31441bcbb9932ecab11a6083cf2119.
race_openbsd_amd64.syso built with LLVM fcf6ae2f070eba73074b6ec8d8281e54d29dbeeb and Go 8f2db14cd35bbd674cb2988a508306de6655e425.

4
src/runtime/race/race.go
View file

@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style // Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file. // license that can be found in the LICENSE file.
//go:build (race && linux && amd64) || (race && freebsd && amd64) || (race && netbsd && amd64) || (race && darwin && amd64) || (race && windows && amd64) || (race && linux && ppc64le) || (race && linux && arm64) || (race && darwin && arm64) //go:build (race && linux && amd64) || (race && freebsd && amd64) || (race && netbsd && amd64) || (race && darwin && amd64) || (race && windows && amd64) || (race && linux && ppc64le) || (race && linux && arm64) || (race && darwin && arm64) || (race && openbsd && amd64)
// +build race,linux,amd64 race,freebsd,amd64 race,netbsd,amd64 race,darwin,amd64 race,windows,amd64 race,linux,ppc64le race,linux,arm64 race,darwin,arm64 // +build race,linux,amd64 race,freebsd,amd64 race,netbsd,amd64 race,darwin,amd64 race,windows,amd64 race,linux,ppc64le race,linux,arm64 race,darwin,arm64 race,openbsd,amd64
package race package race

BIN
src/runtime/race/race_openbsd_amd64.syso Normal file
View file

Binary file not shown.