From a412b5f0d803b261b8075289bf41599490f237cc Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Tue, 30 Nov 2021 23:21:39 +0100 Subject: [PATCH] runtime: skip TestSignalIgnoreSIGTRAP on all OpenBSD builders TestSignalIgnoreSIGTRAP is flaky on OpenBSD and the cause is suspected to be a kernel bug. This test is currently only skipped on the previous OpenBSD 6.2 and 6.4 builders for #17496. In the meantime the OpenBSD builders were upgraded to more recent OpenBSD versions (currently 6.8 and 7.0). It seems the issue is still present in these OpenBSD versions and there is no obvious workaround in Go. Thus, skip the flaky test on OpenBSD in general. Updates #17496 Updates #49725 Change-Id: I3577d287dcfaad7a81679db2e71540854fce065a Reviewed-on: https://go-review.googlesource.com/c/go/+/367115 Trust: Tobias Klauser Run-TryBot: Tobias Klauser TryBot-Result: Go Bot Reviewed-by: Emmanuel Odeke Reviewed-by: Bryan C. Mills --- src/runtime/crash_unix_test.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/runtime/crash_unix_test.go b/src/runtime/crash_unix_test.go index 0930a1b365..b93a760276 100644 --- a/src/runtime/crash_unix_test.go +++ b/src/runtime/crash_unix_test.go @@ -14,7 +14,6 @@ import ( "os/exec" "runtime" "runtime/debug" - "strings" "sync" "syscall" "testing" @@ -250,9 +249,7 @@ func TestSignalExitStatus(t *testing.T) { func TestSignalIgnoreSIGTRAP(t *testing.T) { if runtime.GOOS == "openbsd" { - if bn := testenv.Builder(); strings.HasSuffix(bn, "-62") || strings.HasSuffix(bn, "-64") { - testenv.SkipFlaky(t, 17496) - } + testenv.SkipFlaky(t, 49725) } output := runTestProg(t, "testprognet", "SignalIgnoreSIGTRAP")