languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-15 22:20:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

net/netip: add missing ) in ParsePrefix errors

Browse source 
The existing error messages didn't add right parenthesis ')' properly
leading to improper formation of error messages.

Fixes #53283

Change-Id: Iadf9b8059403efa07e39716a81fab68cd10b7f87
Reviewed-on: https://go-review.googlesource.com/c/go/+/411015
Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Damien Neil <dneil@google.com>
This commit is contained in:
subham sarkar 2022-06-08 15:08:33 +05:30 committed by Gopher Robot
parent c2c76c6f19
commit 937fa5000a
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/net/netip/netip.go
View file

@ -1310,14 +1310,14 @@ func ParsePrefix(s string) (Prefix, error) {
bitsStr := s[i+1:] bitsStr := s[i+1:]
bits, err := strconv.Atoi(bitsStr) bits, err := strconv.Atoi(bitsStr)
if err != nil { if err != nil {
return Prefix{}, errors.New("netip.ParsePrefix(" + strconv.Quote(s) + ": bad bits after slash: " + strconv.Quote(bitsStr)) return Prefix{}, errors.New("netip.ParsePrefix(" + strconv.Quote(s) + "): bad bits after slash: " + strconv.Quote(bitsStr))
} }
maxBits := 32 maxBits := 32
if ip.Is6() { if ip.Is6() {
maxBits = 128 maxBits = 128
} }
if bits < 0 || bits > maxBits { if bits < 0 || bits > maxBits {
return Prefix{}, errors.New("netip.ParsePrefix(" + strconv.Quote(s) + ": prefix length out of range") return Prefix{}, errors.New("netip.ParsePrefix(" + strconv.Quote(s) + "): prefix length out of range")
} }
return PrefixFrom(ip, bits), nil return PrefixFrom(ip, bits), nil
} }