languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-15 22:20:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/go/internal/work: remove a redundant call to modload.LoadedModules

Browse source 
The modload.EditBuildList call added in CL 270980 already ensures that
installMod does not require a newer version of itself, so the condition
that this loop is checking for is redundant.

(I had meant for this change to be included in CL 270980, but
apparently somehow reverted it prior to mailing.)

For #36460

Change-Id: I4dd746b927f7012d950187cac9c510cd6fec8fd9
Reviewed-on: https://go-review.googlesource.com/c/go/+/271646
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Trust: Bryan C. Mills <bcmills@google.com>
This commit is contained in:
Bryan C. Mills 2020-11-19 13:26:51 -05:00
parent 66c0264506
commit 8bbd8294d0
1 changed files with 0 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/cmd/go/internal/work/build.go
View file

@ -840,11 +840,6 @@ func installOutsideModule(ctx context.Context, args []string) {
}
// Check that named packages are all provided by the same module.
for _, mod := range modload.LoadedModules() {
if mod.Path == installMod.Path && mod.Version != installMod.Version {
base.Fatalf("go install: %s: module requires a higher version of itself (%s)", installMod, mod.Version)
}
}
for _, pkg := range mainPkgs {
if pkg.Module == nil {
// Packages in std, cmd, and their vendored dependencies