mirror of
https://github.com/golang/go
synced 2024-09-06 00:19:45 +00:00
cmd/8g: fix miscompilation due to BADWIDTH.
Fixes #3899. R=rsc CC=golang-dev, remy https://golang.org/cl/6453084
This commit is contained in:
parent
f4f1ba2b1e
commit
823962c521
|
@ -1853,6 +1853,7 @@ naddr(Node *n, Addr *a, int canemitcode)
|
|||
a->width = 0;
|
||||
if(n->type != T) {
|
||||
a->etype = simtype[n->type->etype];
|
||||
dowidth(n->type);
|
||||
a->width = n->type->width;
|
||||
a->gotype = ngotype(n);
|
||||
}
|
||||
|
|
28
test/fixedbugs/bug450.go
Normal file
28
test/fixedbugs/bug450.go
Normal file
|
@ -0,0 +1,28 @@
|
|||
// run
|
||||
|
||||
// Copyright 2012 The Go Authors. All rights reserved.
|
||||
// Use of this source code is governed by a BSD-style
|
||||
// license that can be found in the LICENSE file.
|
||||
|
||||
// Issue 3899: 8g incorrectly thinks a variable is
|
||||
// "set but not used" and elides an assignment, causing
|
||||
// variables to end up with wrong data.
|
||||
//
|
||||
// The reason is a miscalculation of variable width.
|
||||
|
||||
package main
|
||||
|
||||
func bar(f func()) {
|
||||
f()
|
||||
}
|
||||
|
||||
func foo() {
|
||||
f := func() {}
|
||||
if f == nil {
|
||||
}
|
||||
bar(f)
|
||||
}
|
||||
|
||||
func main() {
|
||||
foo()
|
||||
}
|
Loading…
Reference in a new issue