languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-06 00:19:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

internal/trace: fix off-by-one error in arguments for exp events

Browse source 
There's an off-by-one error in computing the Args field for experimental
events, resulting in confusing output. This wasn't caught because no
test actually checks to make sure the experimental arguments make sense
yet.

Change-Id: I339677a80bee6319407fced20d5e0f9c2fd235b3
Reviewed-on: https://go-review.googlesource.com/c/go/+/589055
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
This commit is contained in:
Michael Anthony Knyszek 2024-05-29 16:10:27 +00:00 committed by Gopher Robot
parent 787414ca48
commit 81d424ee9a
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/internal/trace/event.go
View file

@ -663,11 +663,11 @@ func (e Event) Experimental() ExperimentalEvent {
panic("Experimental called on non-Experimental event")
}
spec := go122.Specs()[e.base.typ]
argNames := spec.Args[1:]
argNames := spec.Args[1:] // Skip timestamp; already handled.
return ExperimentalEvent{
Name: spec.Name,
ArgNames: argNames, // Skip timestamp; already handled.
Args: e.base.args[1 : 1+len(argNames)],
ArgNames: argNames,
Args: e.base.args[:len(argNames)],
Data: e.table.expData[spec.Experiment],
}
}