mirror of
https://github.com/golang/go
synced 2024-10-02 22:25:08 +00:00
Revert "cmd/compile: make isfat handle 1-element array, 1-field struct"
This reverts commit 5322776215
.
Reason for revert: broke js-wasm builder.
Change-Id: If22762317c4a9e00f5060eb84377a4a52d601fca
Reviewed-on: https://go-review.googlesource.com/c/go/+/192157
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
This commit is contained in:
parent
aced50af3b
commit
777304a5d3
|
@ -1453,21 +1453,9 @@ func liveness(e *ssafn, f *ssa.Func, pp *Progs) LivenessMap {
|
|||
func isfat(t *types.Type) bool {
|
||||
if t != nil {
|
||||
switch t.Etype {
|
||||
case TSLICE, TSTRING,
|
||||
case TSTRUCT, TARRAY, TSLICE, TSTRING,
|
||||
TINTER: // maybe remove later
|
||||
return true
|
||||
case TARRAY:
|
||||
// Array of 1 element, check if element is fat
|
||||
if t.NumElem() == 1 {
|
||||
return isfat(t.Elem())
|
||||
}
|
||||
return true
|
||||
case TSTRUCT:
|
||||
// Struct with 1 field, check if field is fat
|
||||
if t.NumFields() == 1 {
|
||||
return isfat(t.Field(0).Type)
|
||||
}
|
||||
return true
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
@ -659,7 +659,7 @@ func bad40() {
|
|||
|
||||
func good40() {
|
||||
ret := T40{} // ERROR "stack object ret T40$"
|
||||
ret.m = make(map[int]int) // ERROR "live at call to fastrand: .autotmp_[0-9]+$" "stack object .autotmp_[0-9]+ map.hdr\[int\]int$"
|
||||
ret.m = make(map[int]int) // ERROR "live at call to fastrand: .autotmp_[0-9]+ ret$" "stack object .autotmp_[0-9]+ map.hdr\[int\]int$"
|
||||
t := &ret
|
||||
printnl() // ERROR "live at call to printnl: ret$"
|
||||
// Note: ret is live at the printnl because the compiler moves &ret
|
||||
|
|
|
@ -27,14 +27,14 @@ func newT40() *T40 {
|
|||
}
|
||||
|
||||
func bad40() {
|
||||
t := newT40() // ERROR "stack object ret T40$" "stack object .autotmp_[0-9]+ map.hdr\[int\]int$"
|
||||
t := newT40() // ERROR "live at call to makemap: ret$" "stack object ret T40$" "stack object .autotmp_[0-9]+ map.hdr\[int\]int$"
|
||||
printnl() // ERROR "live at call to printnl: ret$"
|
||||
useT40(t)
|
||||
}
|
||||
|
||||
func good40() {
|
||||
ret := T40{} // ERROR "stack object ret T40$"
|
||||
ret.m = make(map[int]int, 42) // ERROR "stack object .autotmp_[0-9]+ map.hdr\[int\]int$"
|
||||
ret.m = make(map[int]int, 42) // ERROR "live at call to makemap: ret$" "stack object .autotmp_[0-9]+ map.hdr\[int\]int$"
|
||||
t := &ret
|
||||
printnl() // ERROR "live at call to printnl: ret$"
|
||||
useT40(t)
|
||||
|
|
Loading…
Reference in a new issue