languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-10-14 11:53:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/8g: add a few missing splitclean

Browse source 
Fixes #887.

R=ken2
CC=golang-dev
https://golang.org/cl/7303061
This commit is contained in:
Russ Cox 2013-02-07 17:55:25 -05:00
parent 2b44c33b4a
commit 7594440ef1
3 changed files with 39 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/cmd/8g/ggen.c
View file

@ -704,6 +704,7 @@ cgen_shift(int op, int bounded, Node *nl, Node *nr, Node *res)
regalloc(&n1, types[TUINT32], &n1); // to hold the shift type in CX
split64(&nt, &lo, &hi);
gmove(&lo, &n1);
splitclean();
}
} else {
if(nr->type->width > 4) {
@ -716,6 +717,7 @@ cgen_shift(int op, int bounded, Node *nl, Node *nr, Node *res)
p2 = gbranch(optoas(ONE, types[TUINT32]), T, +1);
gins(optoas(OCMP, types[TUINT32]), &n1, ncon(w));
p1 = gbranch(optoas(OLT, types[TUINT32]), T, +1);
splitclean();
patch(p2, pc);
} else {
gins(optoas(OCMP, nr->type), &n1, ncon(w));

2
src/cmd/8g/gsubr.c
View file

@ -1168,9 +1168,9 @@ split64(Node *n, Node *lo, Node *hi)
if(!is64(n->type))
fatal("split64 %T", n->type);
sclean[nsclean].op = OEMPTY;
if(nsclean >= nelem(sclean))
fatal("split64 clean");
sclean[nsclean].op = OEMPTY;
nsclean++;
switch(n->op) {
default:

36
test/fixedbugs/issue887.go Normal file
View file

@ -0,0 +1,36 @@
// compile
// Copyright 2013 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// Used to leak registers on 8g.
package p
func f(x byte, y uint64) {
var r byte
switch y {
case 1:
r = x << y // '>>' triggers it too
case 2:
r = x << y
case 3:
r = x << y
case 4:
r = x << y
case 5:
r = x << y
case 6:
r = x << y
case 7:
r = x << y
case 8:
r = x << y
case 9:
r = x << y
case 10:
r = x << y
}
_ = r
}