From 6f37fee354e941c6f143b34014c269943962b116 Mon Sep 17 00:00:00 2001 From: David du Colombier <0intro@gmail.com> Date: Wed, 31 Jan 2018 22:56:39 +0100 Subject: [PATCH] cmd/go: fix TestNoCache on Plan 9 CL 91097 added TestNoCache. However, this test is failing on Plan 9 because the HOME environment variable doesn't contain the home directory where the Go cache is located. This change fixes the TestNoCache test by using the home environment variable instead of HOME on Plan 9. Fixes #23644. Change-Id: Icfb7a7a4c2852f159c93032b4081411628a2787f Reviewed-on: https://go-review.googlesource.com/91216 Run-TryBot: David du Colombier <0intro@gmail.com> Reviewed-by: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/cmd/go/go_test.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go index b2053f553c..ac47adb8e7 100644 --- a/src/cmd/go/go_test.go +++ b/src/cmd/go/go_test.go @@ -5387,7 +5387,11 @@ func TestNoCache(t *testing.T) { tg.parallel() tg.tempFile("triv.go", `package main; func main() {}`) tg.must(os.MkdirAll(tg.path("unwritable"), 0555)) - tg.setenv("HOME", tg.path(filepath.Join("unwritable", "home"))) + home := "HOME" + if runtime.GOOS == "plan9" { + home = "home" + } + tg.setenv(home, tg.path(filepath.Join("unwritable", "home"))) tg.unsetenv("GOCACHE") tg.run("build", "-o", tg.path("triv"), tg.path("triv.go")) tg.grepStderr("disabling cache", "did not disable cache")