From 6933d76a7eec7a197c3416ea9f15b508ac931477 Mon Sep 17 00:00:00 2001 From: Keith Randall Date: Sat, 6 Oct 2018 08:56:03 -0700 Subject: [PATCH] cmd/compile: allow VARDEF at top level This was missed as part of adding a top-level VARDEF for stack tracing (CL 134156). Fixes #28055 Change-Id: Id14748dfccb119197d788867d2ec6a3b3c9835cf Reviewed-on: https://go-review.googlesource.com/c/140304 Run-TryBot: Keith Randall TryBot-Result: Gobot Gobot Reviewed-by: Alberto Donizetti --- src/cmd/compile/internal/gc/walk.go | 1 + test/fixedbugs/issue28055.go | 16 ++++++++++++++++ 2 files changed, 17 insertions(+) create mode 100644 test/fixedbugs/issue28055.go diff --git a/src/cmd/compile/internal/gc/walk.go b/src/cmd/compile/internal/gc/walk.go index 1c398ef43c..80fdc55b5d 100644 --- a/src/cmd/compile/internal/gc/walk.go +++ b/src/cmd/compile/internal/gc/walk.go @@ -211,6 +211,7 @@ func walkstmt(n *Node) *Node { ODCLCONST, ODCLTYPE, OCHECKNIL, + OVARDEF, OVARKILL, OVARLIVE: break diff --git a/test/fixedbugs/issue28055.go b/test/fixedbugs/issue28055.go new file mode 100644 index 0000000000..d4889d54d4 --- /dev/null +++ b/test/fixedbugs/issue28055.go @@ -0,0 +1,16 @@ +// compile + +// Copyright 2018 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +// Make sure VARDEF can be a top-level statement. + +package p + +func f() { + var s string + var as []string + switch false && (s+"a"+as[0]+s+as[0]+s == "") { + } +}