languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-04 15:34:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/compile: don't print (empty) package name in errors referring to built-ins

Browse source 
Fixes #14010.

Change-Id: Idfd4b063eecf453fe00f3e798099023707a65963
Reviewed-on: https://go-review.googlesource.com/18738
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Robert Griesemer <gri@golang.org>
This commit is contained in:
Robert Griesemer 2016-01-19 14:17:29 -08:00
parent df2a9e4a33
commit 5395846890
2 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/cmd/compile/internal/gc/fmt.go
View file

@ -419,7 +419,7 @@ func symfmt(s *Sym, flag int) string {
if s.Pkg != nil && flag&obj.FmtShort == 0 {
switch fmtmode {
case FErr: // This is for the user
if s.Pkg == localpkg {
if s.Pkg == builtinpkg || s.Pkg == localpkg {
return s.Name
}

15
test/fixedbugs/issue14010.go Normal file
View file

@ -0,0 +1,15 @@
// errorcheck
// Copyright 2016 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// Verify that built-in types don't get printed with
// (empty) package qualification.
package main
func main() {
true = false // ERROR "cannot assign to true"
byte = 0 // ERROR "not an expression" "cannot assign to byte"
}