mirror of
https://github.com/golang/go
synced 2024-09-15 22:20:06 +00:00
cmd/gc: use a register to checknil constants.
Fixes #7346. LGTM=rsc R=rsc, iant, khr CC=golang-codereviews https://golang.org/cl/69050044
This commit is contained in:
parent
0a3bd045f5
commit
52e6d7c622
|
@ -476,7 +476,7 @@ cgen_checknil(Node *n)
|
||||||
dump("checknil", n);
|
dump("checknil", n);
|
||||||
fatal("bad checknil");
|
fatal("bad checknil");
|
||||||
}
|
}
|
||||||
if((thechar == '5' && n->op != OREGISTER) || !n->addable) {
|
if((thechar == '5' && n->op != OREGISTER) || !n->addable || n->op == OLITERAL) {
|
||||||
regalloc(®, types[tptr], n);
|
regalloc(®, types[tptr], n);
|
||||||
cgen(n, ®);
|
cgen(n, ®);
|
||||||
gins(ACHECKNIL, ®, N);
|
gins(ACHECKNIL, ®, N);
|
||||||
|
|
14
test/fixedbugs/issue7346.go
Normal file
14
test/fixedbugs/issue7346.go
Normal file
|
@ -0,0 +1,14 @@
|
||||||
|
// compile
|
||||||
|
|
||||||
|
// Copyright 2014 The Go Authors. All rights reserved.
|
||||||
|
// Use of this source code is governed by a BSD-style
|
||||||
|
// license that can be found in the LICENSE file.
|
||||||
|
|
||||||
|
// issue 7346 : internal error "doasm" error due to checknil
|
||||||
|
// of a nil literal.
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
func main() {
|
||||||
|
_ = *(*int)(nil)
|
||||||
|
}
|
Loading…
Reference in a new issue