mirror of
https://github.com/golang/go
synced 2024-09-15 22:20:06 +00:00
cmd/go: make fewer 'go mod' commands update go.mod
'go mod graph', 'go mod vendor', 'go mod verify', and 'go mod why' will no longer edit go.mod or go.sum. 'go mod graph', 'go mod verify', and 'go mod why' may still fetch files and look up packages as if they were able to update go.mod. They're useful for debugging and should still work when go.mod is a little broken. This is implemented in modload.setDefaultBuildMod based on command name for now. Super gross. Sorry. This should be fixed with a larger refactoring for #40775. Fixes golang/go#45551 Change-Id: If5f225937180d32e9a5dd252c78d988042bbdedf Reviewed-on: https://go-review.googlesource.com/c/go/+/336151 Trust: Jay Conrod <jayconrod@google.com> Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org> Reviewed-on: https://go-review.googlesource.com/c/go/+/341933 Reviewed-by: Bryan C. Mills <bcmills@google.com>
This commit is contained in:
parent
1fffeddfe9
commit
4be75faa3e
|
@ -686,12 +686,25 @@ func setDefaultBuildMod() {
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
if cfg.CmdName == "get" || strings.HasPrefix(cfg.CmdName, "mod ") {
|
// TODO(#40775): commands should pass in the module mode as an option
|
||||||
// 'get' and 'go mod' commands may update go.mod automatically.
|
// to modload functions instead of relying on an implicit setting
|
||||||
// TODO(jayconrod): should this narrower? Should 'go mod download' or
|
// based on command name.
|
||||||
// 'go mod graph' update go.mod by default?
|
switch cfg.CmdName {
|
||||||
|
case "get", "mod download", "mod init", "mod tidy":
|
||||||
|
// These commands are intended to update go.mod and go.sum.
|
||||||
cfg.BuildMod = "mod"
|
cfg.BuildMod = "mod"
|
||||||
return
|
return
|
||||||
|
case "mod graph", "mod verify", "mod why":
|
||||||
|
// These commands should not update go.mod or go.sum, but they should be
|
||||||
|
// able to fetch modules not in go.sum and should not report errors if
|
||||||
|
// go.mod is inconsistent. They're useful for debugging, and they need
|
||||||
|
// to work in buggy situations.
|
||||||
|
cfg.BuildMod = "mod"
|
||||||
|
allowWriteGoMod = false
|
||||||
|
return
|
||||||
|
case "mod vendor":
|
||||||
|
cfg.BuildMod = "readonly"
|
||||||
|
return
|
||||||
}
|
}
|
||||||
if modRoot == "" {
|
if modRoot == "" {
|
||||||
if allowMissingModuleImports {
|
if allowMissingModuleImports {
|
||||||
|
|
2
src/cmd/go/testdata/script/mod_all.txt
vendored
2
src/cmd/go/testdata/script/mod_all.txt
vendored
|
@ -315,7 +315,7 @@ go 1.15
|
||||||
|
|
||||||
require (
|
require (
|
||||||
example.com/a v0.1.0
|
example.com/a v0.1.0
|
||||||
example.com/b v0.1.0
|
example.com/b v0.1.0 // indirect
|
||||||
example.com/q v0.1.0
|
example.com/q v0.1.0
|
||||||
example.com/r v0.1.0 // indirect
|
example.com/r v0.1.0 // indirect
|
||||||
example.com/t v0.1.0
|
example.com/t v0.1.0
|
||||||
|
|
23
src/cmd/go/testdata/script/mod_e.txt
vendored
23
src/cmd/go/testdata/script/mod_e.txt
vendored
|
@ -24,11 +24,11 @@ cmp go.mod.orig go.mod
|
||||||
|
|
||||||
! go mod vendor
|
! go mod vendor
|
||||||
|
|
||||||
stderr '^example.com/untidy imports\n\texample.net/directnotfound: cannot find module providing package example.net/directnotfound: module example.net/directnotfound: reading http://.*: 404 Not Found$'
|
stderr '^example.com/untidy imports\n\texample.net/directnotfound: no required module provides package example.net/directnotfound; to add it:\n\tgo get example.net/directnotfound$'
|
||||||
|
|
||||||
stderr '^example.com/untidy imports\n\texample.net/m imports\n\texample.net/indirectnotfound: cannot find module providing package example.net/indirectnotfound: module example.net/indirectnotfound: reading http://.*: 404 Not Found$'
|
stderr '^example.com/untidy imports\n\texample.net/m: module example.net/m provides package example.net/m and is replaced but not required; to add it:\n\tgo get example.net/m@v0.1.0$'
|
||||||
|
|
||||||
stderr '^example.com/untidy tested by\n\texample.com/untidy.test imports\n\texample.net/directtestnotfound: cannot find module providing package example.net/directtestnotfound: module example.net/directtestnotfound: reading http://.*: 404 Not Found$'
|
stderr '^example.com/untidy tested by\n\texample.com/untidy.test imports\n\texample.net/directtestnotfound: no required module provides package example.net/directtestnotfound; to add it:\n\tgo get example.net/directtestnotfound$'
|
||||||
|
|
||||||
! stderr 'indirecttestnotfound' # Vendor prunes test dependencies.
|
! stderr 'indirecttestnotfound' # Vendor prunes test dependencies.
|
||||||
|
|
||||||
|
@ -43,16 +43,23 @@ stderr -count=4 'cannot find module providing package'
|
||||||
cmp go.mod.final go.mod
|
cmp go.mod.final go.mod
|
||||||
|
|
||||||
|
|
||||||
# 'go mod vendor -e' still logs the errors, but succeeds and updates go.mod.
|
# 'go mod vendor -e' still logs the errors, but creates a vendor directory
|
||||||
|
# and exits with status 0.
|
||||||
|
# 'go mod vendor -e' does not update go.mod and will not vendor packages that
|
||||||
|
# would require changing go.mod, for example, by adding a requirement.
|
||||||
cp go.mod.orig go.mod
|
cp go.mod.orig go.mod
|
||||||
go mod vendor -e
|
go mod vendor -e
|
||||||
stderr -count=3 'cannot find module providing package'
|
stderr -count=2 'no required module provides package'
|
||||||
cmp go.mod.final go.mod
|
stderr '^example.com/untidy imports\n\texample.net/m: module example.net/m provides package example.net/m and is replaced but not required; to add it:\n\tgo get example.net/m@v0.1.0$'
|
||||||
|
exists vendor/modules.txt
|
||||||
|
! exists vendor/example.net
|
||||||
|
|
||||||
|
go mod edit -require example.net/m@v0.1.0
|
||||||
|
go mod vendor -e
|
||||||
|
stderr -count=3 'no required module provides package'
|
||||||
exists vendor/modules.txt
|
exists vendor/modules.txt
|
||||||
exists vendor/example.net/m/m.go
|
exists vendor/example.net/m/m.go
|
||||||
|
|
||||||
|
|
||||||
-- go.mod --
|
-- go.mod --
|
||||||
module example.com/untidy
|
module example.com/untidy
|
||||||
go 1.16
|
go 1.16
|
||||||
|
|
|
@ -44,7 +44,7 @@ go mod edit -require rsc.io/quote@23179ee
|
||||||
grep 'rsc.io/quote 23179ee' go.mod
|
grep 'rsc.io/quote 23179ee' go.mod
|
||||||
|
|
||||||
# but other commands fix them
|
# but other commands fix them
|
||||||
go mod graph
|
go list -m -mod=mod all
|
||||||
grep 'rsc.io/quote v1.5.1' go.mod
|
grep 'rsc.io/quote v1.5.1' go.mod
|
||||||
|
|
||||||
-- go.mod --
|
-- go.mod --
|
||||||
|
|
|
@ -25,6 +25,7 @@ stderr 'go list -m: can''t match module patterns using the vendor directory\n\t\
|
||||||
-- go.mod --
|
-- go.mod --
|
||||||
module x
|
module x
|
||||||
|
|
||||||
|
go 1.16
|
||||||
-- x.go --
|
-- x.go --
|
||||||
package x
|
package x
|
||||||
import _ "rsc.io/quote"
|
import _ "rsc.io/quote"
|
||||||
|
|
|
@ -101,7 +101,9 @@ module example.com/use
|
||||||
go 1.15
|
go 1.15
|
||||||
|
|
||||||
require example.com/retract v1.0.0-bad
|
require example.com/retract v1.0.0-bad
|
||||||
|
-- go.sum --
|
||||||
|
example.com/retract v1.0.0-bad h1:liAW69rbtjY67x2CcNzat668L/w+YGgNX3lhJsWIJis=
|
||||||
|
example.com/retract v1.0.0-bad/go.mod h1:0DvGGofJ9hr1q63cBrOY/jSY52OwhRGA0K47NE80I5Y=
|
||||||
-- use.go --
|
-- use.go --
|
||||||
package use
|
package use
|
||||||
|
|
||||||
|
|
8
src/cmd/go/testdata/script/mod_retention.txt
vendored
8
src/cmd/go/testdata/script/mod_retention.txt
vendored
|
@ -39,12 +39,14 @@ go list -mod=mod all
|
||||||
cmp go.mod go.mod.tidy
|
cmp go.mod go.mod.tidy
|
||||||
|
|
||||||
# "// indirect" comments should be added if appropriate.
|
# "// indirect" comments should be added if appropriate.
|
||||||
|
# TODO(#42504): add case for 'go list -mod=mod -tags=any all' when -tags=any
|
||||||
|
# is supported. Only a command that loads "all" without build constraints
|
||||||
|
# (except "ignore") has enough information to add "// indirect" comments.
|
||||||
|
# 'go mod tidy' and 'go mod vendor' are the only commands that do that,
|
||||||
|
# but 'go mod vendor' cannot write go.mod.
|
||||||
cp go.mod.toodirect go.mod
|
cp go.mod.toodirect go.mod
|
||||||
go list all
|
go list all
|
||||||
cmp go.mod go.mod.toodirect
|
cmp go.mod go.mod.toodirect
|
||||||
go mod vendor # loads everything, so adds "// indirect" comments.
|
|
||||||
cmp go.mod go.mod.tidy
|
|
||||||
rm -r vendor
|
|
||||||
|
|
||||||
|
|
||||||
# Redundant requirements should be preserved...
|
# Redundant requirements should be preserved...
|
||||||
|
|
|
@ -10,8 +10,8 @@ stderr '^issue27063 imports\n\tissue27063/other imports\n\tother.example.com/non
|
||||||
|
|
||||||
! go mod vendor
|
! go mod vendor
|
||||||
! stderr 'package nonexist is not in GOROOT'
|
! stderr 'package nonexist is not in GOROOT'
|
||||||
stderr '^issue27063 imports\n\tnonexist.example.com: cannot find module providing package nonexist.example.com'
|
stderr '^issue27063 imports\n\tnonexist.example.com: no required module provides package nonexist.example.com; to add it:\n\tgo get nonexist.example.com$'
|
||||||
stderr '^issue27063 imports\n\tissue27063/other imports\n\tother.example.com/nonexist: cannot find module providing package other.example.com/nonexist'
|
stderr '^issue27063 imports\n\tissue27063/other imports\n\tother.example.com/nonexist: no required module provides package other.example.com/nonexist; to add it:\n\tgo get other.example.com/nonexist$'
|
||||||
|
|
||||||
-- go.mod --
|
-- go.mod --
|
||||||
module issue27063
|
module issue27063
|
||||||
|
|
|
@ -36,7 +36,6 @@ module example.com/replace
|
||||||
|
|
||||||
require rsc.io/quote/v3 v3.0.0
|
require rsc.io/quote/v3 v3.0.0
|
||||||
replace rsc.io/quote/v3 => ./local/not-rsc.io/quote/v3
|
replace rsc.io/quote/v3 => ./local/not-rsc.io/quote/v3
|
||||||
|
|
||||||
-- imports.go --
|
-- imports.go --
|
||||||
package replace
|
package replace
|
||||||
|
|
||||||
|
@ -64,3 +63,7 @@ require (
|
||||||
not-rsc.io/quote/v3 v3.0.0
|
not-rsc.io/quote/v3 v3.0.0
|
||||||
)
|
)
|
||||||
replace not-rsc.io/quote/v3 => rsc.io/quote/v3 v3.0.0
|
replace not-rsc.io/quote/v3 => rsc.io/quote/v3 v3.0.0
|
||||||
|
-- multiple-paths/go.sum --
|
||||||
|
golang.org/x/text v0.0.0-20170915032832-14c0d48ead0c/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
|
||||||
|
rsc.io/quote/v3 v3.0.0/go.mod h1:yEA65RcK8LyAZtP9Kv3t0HmxON59tX3rD+tICJqUlj0=
|
||||||
|
rsc.io/sampler v1.3.0/go.mod h1:T1hPZKmBbMNahiBKFy5HrXp6adAjACjK9JXDnKaTXpA=
|
||||||
|
|
|
@ -29,8 +29,12 @@ stdout '^example.com/stack@v1.0.0/stack.go$'
|
||||||
-- go.mod --
|
-- go.mod --
|
||||||
module example.com/main
|
module example.com/main
|
||||||
|
|
||||||
require example.com/stack v1.0.0
|
go 1.17
|
||||||
|
|
||||||
|
require example.com/stack v1.0.0
|
||||||
|
-- go.sum --
|
||||||
|
example.com/stack v1.0.0 h1:IEDLeew5NytZ8vrgCF/QVem3H3SR3QMttdu9HfJvk9I=
|
||||||
|
example.com/stack v1.0.0/go.mod h1:7wFEbaV5e5O7wJ8aBdqQOR//UXppm/pwnwziMKViuI4=
|
||||||
-- main.go --
|
-- main.go --
|
||||||
package main
|
package main
|
||||||
|
|
||||||
|
|
|
@ -12,6 +12,8 @@ module example.com/m
|
||||||
go 1.14
|
go 1.14
|
||||||
|
|
||||||
require example.com v1.0.0 // indirect
|
require example.com v1.0.0 // indirect
|
||||||
|
-- go.sum --
|
||||||
|
example.com v1.0.0/go.mod h1:WRiieAqDBb1hVdDXLLdxNtCDWNfehn7FWyPC5Oz2vB4=
|
||||||
-- go1.14-modules.txt --
|
-- go1.14-modules.txt --
|
||||||
# example.com v1.0.0
|
# example.com v1.0.0
|
||||||
## explicit
|
## explicit
|
||||||
|
|
5
src/cmd/go/testdata/script/mod_verify.txt
vendored
5
src/cmd/go/testdata/script/mod_verify.txt
vendored
|
@ -39,11 +39,6 @@ stderr 'go.mod: checksum mismatch'
|
||||||
|
|
||||||
# go.sum should be created and updated automatically.
|
# go.sum should be created and updated automatically.
|
||||||
rm go.sum
|
rm go.sum
|
||||||
go mod graph
|
|
||||||
exists go.sum
|
|
||||||
grep '^rsc.io/quote v1.1.0/go.mod ' go.sum
|
|
||||||
! grep '^rsc.io/quote v1.1.0 ' go.sum
|
|
||||||
|
|
||||||
go mod tidy
|
go mod tidy
|
||||||
grep '^rsc.io/quote v1.1.0/go.mod ' go.sum
|
grep '^rsc.io/quote v1.1.0/go.mod ' go.sum
|
||||||
grep '^rsc.io/quote v1.1.0 ' go.sum
|
grep '^rsc.io/quote v1.1.0 ' go.sum
|
||||||
|
|
5
src/cmd/go/testdata/script/modfile_flag.txt
vendored
5
src/cmd/go/testdata/script/modfile_flag.txt
vendored
|
@ -24,6 +24,11 @@ stdout '^go.alt.mod$'
|
||||||
go mod edit -require rsc.io/quote@v1.5.2
|
go mod edit -require rsc.io/quote@v1.5.2
|
||||||
grep rsc.io/quote go.alt.mod
|
grep rsc.io/quote go.alt.mod
|
||||||
|
|
||||||
|
# 'go list -m' should add sums to the alternate go.sum.
|
||||||
|
go list -m -mod=mod all
|
||||||
|
grep '^rsc.io/quote v1.5.2/go.mod ' go.alt.sum
|
||||||
|
! grep '^rsc.io/quote v1.5.2 ' go.alt.sum
|
||||||
|
|
||||||
# other 'go mod' commands should work. 'go mod vendor' is tested later.
|
# other 'go mod' commands should work. 'go mod vendor' is tested later.
|
||||||
go mod download rsc.io/quote
|
go mod download rsc.io/quote
|
||||||
go mod graph
|
go mod graph
|
||||||
|
|
Loading…
Reference in a new issue