languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-02 08:01:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile/internal/syntax: better error message for incorrect if/switch header

Browse source 
Fixes #23664.

Change-Id: Ic0637e9f896b2fc6502dfbab2d1c4de3c62c0bd2
Reviewed-on: https://go-review.googlesource.com/104616
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Robert Griesemer <gri@golang.org>
This commit is contained in:
Robert Griesemer 2018-04-03 14:39:10 -07:00
parent a818ddd972
commit 4637699e92
2 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/cmd/compile/internal/syntax/parser.go
View file

@ -1824,7 +1824,8 @@ func (p *parser) header(keyword token) (init SimpleStmt, cond Expr, post SimpleS
semi.lit = p.lit
p.next()
} else {
p.want(_Semi)
// asking for a '{' rather than a ';' here leads to a better error message
p.want(_Lbrace)
}
if keyword == _For {
if p.tok != _Semi {

17
test/fixedbugs/issue23664.go Normal file
View file

@ -0,0 +1,17 @@
// errorcheck
// Copyright 2018 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// Verify error messages for incorrect if/switch headers.
package p
func f() {
if f() true { // ERROR "unexpected true, expecting {"
}
switch f() true { // ERROR "unexpected true, expecting {"
}
}