mirror of
https://github.com/golang/go
synced 2024-09-05 16:04:50 +00:00
[dev.regabi] cmd/compile: comment out //go:linkname warning
It's noisy and not doing any harm, and we still have an entire release cycle to revisit and address the issue properly. Updates #42938 Change-Id: I1de5cfb495a8148c9c08b215deba38f2617fb467 Reviewed-on: https://go-review.googlesource.com/c/go/+/274732 Trust: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
This commit is contained in:
parent
77a71e0057
commit
42e46f4ae0
|
@ -275,7 +275,7 @@ func (p *noder) processPragmas() {
|
|||
n := ir.AsNode(lookup(l.local).Def)
|
||||
if n == nil || n.Op() != ir.ONAME {
|
||||
// TODO(mdempsky): Change to p.errorAt before Go 1.17 release.
|
||||
base.WarnfAt(p.makeXPos(l.pos), "//go:linkname must refer to declared function or variable (will be an error in Go 1.17)")
|
||||
// base.WarnfAt(p.makeXPos(l.pos), "//go:linkname must refer to declared function or variable (will be an error in Go 1.17)")
|
||||
continue
|
||||
}
|
||||
if n.Sym().Linkname != "" {
|
||||
|
|
|
@ -16,10 +16,13 @@ var x, y int
|
|||
//go:linkname x ok
|
||||
|
||||
// ERROR "//go:linkname requires linkname argument or -p compiler flag"
|
||||
// ERROR "//go:linkname must refer to declared function or variable"
|
||||
// ERROR "//go:linkname must refer to declared function or variable"
|
||||
// BAD: want error "//go:linkname must refer to declared function or variable"
|
||||
// BAD: want error "//go:linkname must refer to declared function or variable"
|
||||
// ERROR "duplicate //go:linkname for x"
|
||||
|
||||
// The two BAD lines are just waiting for #42938 before we can
|
||||
// re-enable the errors.
|
||||
|
||||
//line linkname2.go:18
|
||||
//go:linkname y
|
||||
//go:linkname nonexist nonexist
|
||||
|
|
Loading…
Reference in a new issue