languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-07-20 08:46:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[dev.regabi] cmd/compile: comment out //go:linkname warning

Browse source 
It's noisy and not doing any harm, and we still have an entire release
cycle to revisit and address the issue properly.

Updates #42938

Change-Id: I1de5cfb495a8148c9c08b215deba38f2617fb467
Reviewed-on: https://go-review.googlesource.com/c/go/+/274732
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
This commit is contained in:
Matthew Dempsky 2020-12-01 22:11:56 -08:00
parent 77a71e0057
commit 42e46f4ae0
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/cmd/compile/internal/gc/noder.go
View file

@ -275,7 +275,7 @@ func (p *noder) processPragmas() {
n := ir.AsNode(lookup(l.local).Def)
if n == nil || n.Op() != ir.ONAME {
// TODO(mdempsky): Change to p.errorAt before Go 1.17 release.
base.WarnfAt(p.makeXPos(l.pos), "//go:linkname must refer to declared function or variable (will be an error in Go 1.17)")
// base.WarnfAt(p.makeXPos(l.pos), "//go:linkname must refer to declared function or variable (will be an error in Go 1.17)")
continue
}
if n.Sym().Linkname != "" {

7
test/linkname2.go
View file

@ -16,10 +16,13 @@ var x, y int
//go:linkname x ok
// ERROR "//go:linkname requires linkname argument or -p compiler flag"
// ERROR "//go:linkname must refer to declared function or variable"
// ERROR "//go:linkname must refer to declared function or variable"
// BAD: want error "//go:linkname must refer to declared function or variable"
// BAD: want error "//go:linkname must refer to declared function or variable"
// ERROR "duplicate //go:linkname for x"
// The two BAD lines are just waiting for #42938 before we can
// re-enable the errors.
//line linkname2.go:18
//go:linkname y
//go:linkname nonexist nonexist