languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-15 22:20:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

gc: make string const comparison unsigned

Browse source 
Make compile-time string const comparison match semantics
of runtime.cmpstring.

Fixes #1515.

R=rsc
CC=golang-dev, rog
https://golang.org/cl/4172049
This commit is contained in:
Jeff R. Allen 2011-02-16 17:57:15 -05:00 committed by Russ Cox
parent 0856731daa
commit 3a2d64789b
2 changed files with 23 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/cmd/gc/const.c
View file

@ -1051,12 +1051,12 @@ int
cmpslit(Node *l, Node *r)
{
int32 l1, l2, i, m;
char *s1, *s2;
uchar *s1, *s2;
l1 = l->val.u.sval->len;
l2 = r->val.u.sval->len;
s1 = l->val.u.sval->s;
s2 = r->val.u.sval->s;
s1 = (uchar*)l->val.u.sval->s;
s2 = (uchar*)r->val.u.sval->s;
m = l1;
if(l2 < m)

20
test/fixedbugs/bug1515.go Normal file
View file

@ -0,0 +1,20 @@
// $G $D/$F.go && $L $F.$A && ./$A.out
// Copyright 2011 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package main
const (
joao = "João"
jose = "José"
)
func main() {
s1 := joao
s2 := jose
if (s1 < s2) != (joao < jose) {
panic("unequal")
}
}