languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-05 07:54:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/compile: fix another invalid switch case panic

Browse source 
Very similar fix to the one made in golang.org/cl/65655. This time it's
for switches on interface values, as we look for duplicates in a
different manner to keep types in mind.

As before, add a small regression test.

Updates #22001.
Fixes #22063.

Change-Id: I9a55d08999aeca262ad276b4649b51848a627b02
Reviewed-on: https://go-review.googlesource.com/66450
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
This commit is contained in:
Daniel Martí 2017-09-27 10:51:24 +01:00
parent 70bcd2c54e
commit 39e523792e
2 changed files with 22 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/cmd/compile/internal/gc/swt.go
View file

@ -640,6 +640,11 @@ func checkDupExprCases(exprname *Node, clauses []*Node) {
if ct := consttype(n); ct < 0 || ct == CTBOOL {
continue
}
// If the value has no type, we have
// already printed an error about it.
if n.Type == nil {
continue
}
tv := typeVal{
typ: n.Type.LongString(),
val: n.Val().Interface(),

17
test/fixedbugs/issue22063.go Normal file
View file

@ -0,0 +1,17 @@
// errorcheck
// Copyright 2017 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// Issue 22063: panic on interface switch case with invalid name
package p
const X = Wrong(0) // ERROR "undefined: Wrong"
func _() {
switch interface{}(nil) {
case X:
}
}