From 32964f9dce9615f7c1072e5ead9e11e6db5d2237 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Fri, 2 Sep 2022 11:36:46 -0400 Subject: [PATCH] net: skip TestLookupPTR when LookupAddr fails with "DNS server failure" For #38111. Change-Id: I43bdd756bde0adcd156cf9750b49b3b989304df7 Reviewed-on: https://go-review.googlesource.com/c/go/+/427915 Reviewed-by: Ian Lance Taylor TryBot-Result: Gopher Robot Auto-Submit: Bryan Mills Run-TryBot: Bryan Mills --- src/net/lookup_windows_test.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/net/lookup_windows_test.go b/src/net/lookup_windows_test.go index b7a60e1278..20e0a1a8f1 100644 --- a/src/net/lookup_windows_test.go +++ b/src/net/lookup_windows_test.go @@ -16,6 +16,7 @@ import ( "regexp" "sort" "strings" + "syscall" "testing" ) @@ -171,6 +172,14 @@ func TestLookupPTR(t *testing.T) { for _, addr := range lookupTestIPs { names, err := LookupAddr(addr) if err != nil { + // The DNSError type stores the error as a string, so it cannot wrap the + // original error code and we cannot check for it here. However, we can at + // least use its error string to identify the correct localized text for + // the error to skip. + var DNS_ERROR_RCODE_SERVER_FAILURE syscall.Errno = 9002 + if strings.HasSuffix(err.Error(), DNS_ERROR_RCODE_SERVER_FAILURE.Error()) { + testenv.SkipFlaky(t, 38111) + } t.Errorf("failed %s: %s", addr, err) } if len(names) == 0 {