languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-15 22:20:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/link/internal/loadpe: handle _main reference properly

Browse source 
When building CGO internal linking on windows 386, make sure to avoid
rewriting references to "_main" to "main" when reading symbols during
host object loading; the main routine defined by the Go runtime is
still named "_main" (not "main"). If we don't do this, we wind up with
an SXREF symbol named "main", which can then cause the loader to pull
an actual "main" symbol out of a host archive, which is undesirable.

Updates #35006.

Change-Id: I3768e3617b560552f4522e9e72af879c6adf7705
Reviewed-on: https://go-review.googlesource.com/c/go/+/410124
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Auto-Submit: Than McIntosh <thanm@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
This commit is contained in:
Than McIntosh 2022-06-03 07:50:58 -04:00 committed by Gopher Robot
parent fc97075949
commit 2fa45a4fcd
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/cmd/link/internal/loadpe/ldpe.go
View file

@ -551,7 +551,13 @@ func (state *peLoaderState) readpesym(pesym *pe.COFFSymbol) (*loader.SymbolBuild
name = strings.TrimPrefix(name, "__imp_") // __imp_Name => Name
}
}
if state.arch.Family == sys.I386 && name[0] == '_' {
// A note on the "_main" exclusion below: the main routine
// defined by the Go runtime is named "_main", not "main", so
// when reading references to _main from a host object we want
// to avoid rewriting "_main" to "main" in this specific
// instance. See #issuecomment-1143698749 on #35006 for more
// details on this problem.
if state.arch.Family == sys.I386 && name[0] == '_' && name != "_main" {
name = name[1:] // _Name => Name
}
}