languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-15 22:20:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/compile: stop treating interface methods like actual functions

Browse source 
Interface methods can't have function bodies, so there's no need to
process their parameter lists as variable declarations. The only
possible reason would be to check for duplicate parameter names and/or
invalid types, but we do that anyway, and have regression tests for it
(test/funcdup.go).

Change-Id: Iedb15335467caa5d872dbab829bf32ab8cf6204d
Reviewed-on: https://go-review.googlesource.com/31430
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Matthew Dempsky 2016-10-17 16:03:27 -07:00
parent 2a441d3078
commit 2b687a7df8
1 changed files with 0 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/cmd/compile/internal/gc/dcl.go
View file

@ -506,21 +506,6 @@ func ifacedcl(n *Node) {
if isblank(n.Left) {
yyerror("methods must have a unique non-blank name")
}
n.Func = new(Func)
n.Func.FCurfn = Curfn
dclcontext = PPARAM
funcstart(n)
funcargs(n.Right)
// funcbody is normally called after the parser has
// seen the body of a function but since an interface
// field declaration does not have a body, we must
// call it now to pop the current declaration context.
dclcontext = PAUTO
funcbody(n)
}
// declare the function proper