mirror of
https://github.com/golang/go
synced 2024-09-05 07:54:46 +00:00
[dev.typeparams] cmd/compile: enable generics syntax with -lang=go1.18
We already use -lang=go1.18 to control the types2 type checker behavior. This CL does the same for the parser. Also, disable an assertion in the unified IR linker that depended on the -G flag. This assertion was more useful during initial bootstrapping of that code, but it's less critical now. With these two changes, "GOEXPERIMENT=unified ./make.bash" is enough to get a fully functional generics-enabled toolchain. There's no need to continue specifying custom compiler flags later on. Change-Id: I7766381926f3bb17eee2e5fcc182a38a39e937e1 Reviewed-on: https://go-review.googlesource.com/c/go/+/332373 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Matthew Dempsky <mdempsky@google.com> Trust: Robert Griesemer <gri@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
This commit is contained in:
parent
30e5f266ed
commit
2aea44204e
|
@ -149,9 +149,11 @@ func (l *linker) relocObj(pr *pkgReader, idx int) int {
|
|||
var ok bool
|
||||
obj, ok = sym.Def.(*ir.Name)
|
||||
|
||||
// Generic types and functions won't have definitions.
|
||||
// Generic types and functions and declared constraint types won't
|
||||
// have definitions.
|
||||
// For now, just generically copy their extension data.
|
||||
if !ok && base.Flag.G == 0 {
|
||||
// TODO(mdempsky): Restore assertion.
|
||||
if !ok && false {
|
||||
base.Fatalf("missing definition for %v", sym)
|
||||
}
|
||||
}
|
||||
|
|
|
@ -9,6 +9,7 @@ import (
|
|||
"fmt"
|
||||
"go/constant"
|
||||
"go/token"
|
||||
"internal/buildcfg"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"runtime"
|
||||
|
@ -30,8 +31,11 @@ import (
|
|||
func LoadPackage(filenames []string) {
|
||||
base.Timer.Start("fe", "parse")
|
||||
|
||||
// -G=3 and unified expect generics syntax, but -G=0 does not.
|
||||
supportsGenerics := base.Flag.G != 0 || buildcfg.Experiment.Unified
|
||||
|
||||
mode := syntax.CheckBranches
|
||||
if base.Flag.G != 0 {
|
||||
if supportsGenerics && types.AllowsGoVersion(types.LocalPkg, 1, 18) {
|
||||
mode |= syntax.AllowGenerics
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue