mirror of
https://github.com/golang/go
synced 2024-10-04 23:20:17 +00:00
cmd/compile: make jump table symbol static
The jump table symbol is accessed only from the function symbol (in the same package), so it can be static. Also, if the function is DUPOK and it is, somehow, compiled differently in two different packages, the linker must choose the jump table symbol associated to the function symbol it chose. Currently the jump table symbol is DUPOK, so that is not guaranteed. Making it static will guarantee that, as each copy of the function symbol refers to its own jump table symbol. For #65783. Change-Id: I27e051d01ef585d07700b75d4dfac5768f16441e Reviewed-on: https://go-review.googlesource.com/c/go/+/565535 Reviewed-by: Keith Randall <khr@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@golang.org>
This commit is contained in:
parent
5428cc4f14
commit
2908352980
|
@ -2131,8 +2131,8 @@ func logicFlags32(x int32) flagConstant {
|
|||
|
||||
func makeJumpTableSym(b *Block) *obj.LSym {
|
||||
s := base.Ctxt.Lookup(fmt.Sprintf("%s.jump%d", b.Func.fe.Func().LSym.Name, b.ID))
|
||||
s.Set(obj.AttrDuplicateOK, true)
|
||||
s.Set(obj.AttrLocal, true)
|
||||
// The jump table symbol is accessed only from the function symbol.
|
||||
s.Set(obj.AttrStatic, true)
|
||||
return s
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue