languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-10-04 15:09:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

encoding/binary: replace constant literals with named constant (cleanup)

Browse source 
Follow-up on https://golang.org/cl/247120.

Brought to my attention by Luke McCoy.

Change-Id: I4530c96fb164d23b0ce5311f2cecb1964f2dea74
Reviewed-on: https://go-review.googlesource.com/c/go/+/249837
Reviewed-by: Katie Hockman <katie@golang.org>
This commit is contained in:
Robert Griesemer 2020-08-21 10:02:44 -07:00
parent bca0b44629
commit 27136419d4
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/encoding/binary/varint.go
View file

@ -62,7 +62,7 @@ func Uvarint(buf []byte) (uint64, int) {
var s uint
for i, b := range buf {
if b < 0x80 {
if i > 9 || i == 9 && b > 1 {
if i >= MaxVarintLen64 || i == MaxVarintLen64-1 && b > 1 {
return 0, -(i + 1) // overflow
}
return x | uint64(b)<<s, i + 1
@ -112,7 +112,7 @@ func ReadUvarint(r io.ByteReader) (uint64, error) {
return x, err
}
if b < 0x80 {
if i == 9 && b > 1 {
if i == MaxVarintLen64-1 && b > 1 {
return x, overflow
}
return x | uint64(b)<<s, nil