languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-07-20 17:48:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[dev.typeparams] cmd/compile/internal/types2: disallow ~T where T is a defined type or an interface

Browse source 
Change-Id: I35f6f43db00d56847da48320308f2fcfff924738
Reviewed-on: https://go-review.googlesource.com/c/go/+/324570
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
This commit is contained in:
Robert Griesemer 2021-06-02 17:05:37 -07:00
parent 8cdce85bdf
commit 10d6b36ca3
4 changed files with 19 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/cmd/compile/internal/types2/testdata/check/typeinst2.go2 vendored
View file

@ -176,12 +176,12 @@ type _ interface {
// Interface type lists can contain any type, incl. *Named types.
// Verify that we use the underlying type to compute the operational type.
type MyInt int
func add1[T interface{~MyInt}](x T) T {
func add1[T interface{MyInt}](x T) T {
return x + 1
}
type MyString string
func double[T interface{~MyInt | ~MyString}](x T) T {
func double[T interface{MyInt|MyString}](x T) T {
return x + x
}

9
src/cmd/compile/internal/types2/testdata/examples/constraints.go2 vendored
View file

@ -24,6 +24,15 @@ type (
_ interface{int|interface /* ERROR cannot use interface */ {}}
)
type (
// Tilde is not permitted on defined types or interfaces.
foo int
bar interface{}
_ interface{foo}
_ interface{~ /* ERROR invalid use of ~ */ foo }
_ interface{~ /* ERROR invalid use of ~ */ bar }
)
// Multiple embedded union elements are intersected. The order in which they
// appear in the interface doesn't matter since intersection is a symmetric
// operation.

4
src/cmd/compile/internal/types2/testdata/fixedbugs/issue39634.go2 vendored
View file

@ -36,8 +36,8 @@ func bar8[A foo8[A]](a A) {}
func main8() {}
// crash 9
type foo9[A any] interface { ~/* ERROR cannot use interface */ foo9[A] }
func _() { var _ = new(foo9 /* ERROR interface contains type constraints */ [int]) }
type foo9[A any] interface { foo9 /* ERROR illegal cycle */ [A] }
func _() { var _ = new(foo9 /* ERROR illegal cycle */ [int]) }
// crash 12
var u /* ERROR cycle */ , i [func /* ERROR used as value */ /* ERROR used as value */ (u, c /* ERROR undeclared */ /* ERROR undeclared */ ) {}(0, len /* ERROR must be called */ /* ERROR must be called */ )]c /* ERROR undeclared */ /* ERROR undeclared */

11
src/cmd/compile/internal/types2/union.go
View file

@ -106,17 +106,18 @@ func parseUnion(check *Checker, tlist []syntax.Expr) Type {
}
u := under(t)
if tilde[i] {
// TODO(gri) enable this check once we have converted tests
// if !Identical(u, t) {
// check.errorf(x, "invalid use of ~ (underlying type of %s is %s)", t, u)
// }
if tilde[i] && !Identical(u, t) {
check.errorf(x, "invalid use of ~ (underlying type of %s is %s)", t, u)
continue // don't report another error for t
}
if _, ok := u.(*Interface); ok {
// A single type with a ~ is a single-term union.
check.errorf(pos, "cannot use interface %s with ~ or inside a union (implementation restriction)", t)
continue // don't report another error for t
}
// Complain about duplicate entries a|a, but also a|~a, and ~a|~a.
// TODO(gri) We should also exclude myint|~int since myint is included in ~int.
if includes(types[:i], t) {
// TODO(gri) this currently doesn't print the ~ if present
check.softErrorf(pos, "duplicate term %s in union element", t)