From 0e01db4b8d6ac64e6661508bc6876fa41c799208 Mon Sep 17 00:00:00 2001 From: Matthew Dempsky Date: Tue, 12 Apr 2016 17:46:41 -0700 Subject: [PATCH] cmd/compile: fix crash on bare package name in constant declarations Fixes #11361. Change-Id: I70b8808f97f0e07de680e7e6ede1322ea0fdbbc0 Reviewed-on: https://go-review.googlesource.com/21936 Reviewed-by: Brad Fitzpatrick --- src/cmd/compile/internal/gc/subr.go | 7 +++++++ test/fixedbugs/issue11361.go | 11 +++++++++++ 2 files changed, 18 insertions(+) create mode 100644 test/fixedbugs/issue11361.go diff --git a/src/cmd/compile/internal/gc/subr.go b/src/cmd/compile/internal/gc/subr.go index 091762f4964..ea2db8721a5 100644 --- a/src/cmd/compile/internal/gc/subr.go +++ b/src/cmd/compile/internal/gc/subr.go @@ -540,8 +540,15 @@ func treecopy(n *Node, lineno int32) *Node { } return n + case OPACK: + // OPACK nodes are never valid in const value declarations, + // but allow them like any other declared symbol to avoid + // crashing (golang.org/issue/11361). + fallthrough + case ONAME, OLITERAL, OTYPE: return n + } } diff --git a/test/fixedbugs/issue11361.go b/test/fixedbugs/issue11361.go new file mode 100644 index 00000000000..d01776b47ca --- /dev/null +++ b/test/fixedbugs/issue11361.go @@ -0,0 +1,11 @@ +// errorcheck + +// Copyright 2016 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +package a + +import "fmt" // ERROR "imported and not used" + +const n = fmt // ERROR "fmt without selector" "fmt is not a constant"