languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-10-14 03:43:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

runtime: simplify signalstack by dropping nil as argument

Browse source 
Change the two calls to signalstack(nil) to inline the code
instead (it's two lines).

Change-Id: Ie92a05494f924f279e40ac159f1b677fda18f281
Reviewed-on: https://go-review.googlesource.com/29854
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Ian Lance Taylor 2016-09-27 07:20:10 -07:00
parent 60482d8a8b
commit 097a581dc0
2 changed files with 6 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/runtime/os_netbsd.go
View file

@ -192,7 +192,8 @@ func newosproc(mp *m, stk unsafe.Pointer) {
// At this point all signals are blocked, so there is no race.
//go:nosplit
func netbsdMstart() {
signalstack(nil)
st := stackt{ss_flags: _SS_DISABLE}
sigaltstack(&st, nil)
mstart()
}

14
src/runtime/signal_unix.go
View file

@ -624,7 +624,8 @@ func minitSignalMask() {
//go:nosplit
func unminitSignals() {
if getg().m.newSigstack {
signalstack(nil)
st := stackt{ss_flags: _SS_DISABLE}
sigaltstack(&st, nil)
}
}
@ -645,17 +646,10 @@ func setGsignalStack(st *stackt) {
}
// signalstack sets the current thread's alternate signal stack to s.
// If s is nil, the current thread's alternate signal stack is disabled.
//go:nosplit
func signalstack(s *stack) {
var st stackt
if s == nil {
st.ss_flags = _SS_DISABLE
} else {
setSignalstackSP(&st, s.lo)
st.ss_size = s.hi - s.lo
st.ss_flags = 0
}
st := stackt{ss_size: s.hi - s.lo}
setSignalstackSP(&st, s.lo)
sigaltstack(&st, nil)
}