languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-30 05:07:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

[release-branch.go1.3] runtime: fix nacl amd64p32 flakiness

Browse source 
««« CL 102710043 / 5640e19d768d
runtime: fix nacl amd64p32 flakiness

newproc takes two extra pointers, not two extra registers.
On amd64p32 (nacl) they are different.

We diagnosed this before the 1.3 cut but the tree was frozen.
I believe this is causing the random problems on the builder.

Fixes #8199.

TBR=r
CC=golang-codereviews
https://golang.org/cl/102710043
»»»

TBR=rsc
CC=golang-codereviews
https://golang.org/cl/124120044
This commit is contained in:
Andrew Gerrand 2014-08-12 09:29:29 +10:00
parent 329d3ce984
commit 0752bc8f26
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/pkg/runtime/traceback_x86.c
View file

@ -214,7 +214,7 @@ runtime·gentraceback(uintptr pc0, uintptr sp0, uintptr lr0, G *gp, int32 skip,
// the SP is two words lower than normal.
sparg = frame.sp;
if(wasnewproc)
sparg += 2*sizeof(uintreg);
sparg += 2*sizeof(uintptr);
// Determine frame's 'continuation PC', where it can continue.
// Normally this is the return address on the stack, but if sigpanic