2012-02-17 04:48:57 +00:00
|
|
|
// errorcheck
|
2011-12-02 17:30:56 +00:00
|
|
|
|
2016-04-10 21:32:26 +00:00
|
|
|
// Copyright 2011 The Go Authors. All rights reserved.
|
2011-12-02 17:30:56 +00:00
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
2012-02-19 02:19:43 +00:00
|
|
|
// Verify that illegal composite literals are detected.
|
|
|
|
// Does not compile.
|
|
|
|
|
2011-12-02 17:30:56 +00:00
|
|
|
package main
|
|
|
|
|
|
|
|
var m map[int][3]int
|
2011-12-02 19:13:12 +00:00
|
|
|
|
2011-12-02 17:30:56 +00:00
|
|
|
func f() [3]int
|
|
|
|
|
|
|
|
func fp() *[3]int
|
2011-12-02 19:13:12 +00:00
|
|
|
|
2011-12-02 17:30:56 +00:00
|
|
|
var mp map[int]*[3]int
|
|
|
|
|
|
|
|
var (
|
2011-12-02 19:13:12 +00:00
|
|
|
_ = [3]int{1, 2, 3}[:] // ERROR "slice of unaddressable value"
|
|
|
|
_ = m[0][:] // ERROR "slice of unaddressable value"
|
|
|
|
_ = f()[:] // ERROR "slice of unaddressable value"
|
|
|
|
|
test: match gofrontend error messages
These changes match the following gofrontend error messages:
blank1.go:16:1: error: may not define methods on non-local type
chan/perm.go:28:9: error: expected channel
chan/perm.go:29:11: error: left operand of ‘<-’ must be channel
chan/perm.go:69:9: error: argument must be channel
complit1.go:25:16: error: attempt to slice object that is not array, slice, or string
complit1.go:26:16: error: attempt to slice object that is not array, slice, or string
complit1.go:27:17: error: attempt to slice object that is not array, slice, or string
complit1.go:49:41: error: may only omit types within composite literals of slice, array, or map type
complit1.go:50:14: error: expected struct, slice, array, or map type for composite literal
convlit.go:24:9: error: invalid type conversion (cannot use type unsafe.Pointer as type string)
convlit.go:25:9: error: invalid type conversion (cannot use type unsafe.Pointer as type float64)
convlit.go:26:9: error: invalid type conversion (cannot use type unsafe.Pointer as type int)
ddd1.go:63:9: error: invalid use of ‘...’ calling non-variadic function
fixedbugs/bug176.go:12:18: error: index expression is not integer constant
fixedbugs/bug332.go:17:10: error: use of undefined type ‘T’
fixedbugs/issue4232.go:22:16: error: integer constant overflow
fixedbugs/issue4232.go:33:16: error: integer constant overflow
fixedbugs/issue4232.go:44:25: error: integer constant overflow
fixedbugs/issue4232.go:55:16: error: integer constant overflow
fixedbugs/issue4458.go:19:14: error: type has no method ‘foo’
fixedbugs/issue5172.go:24:14: error: too many expressions for struct
init.go:17:9: error: reference to undefined name ‘runtime’
initializerr.go:26:29: error: duplicate value for index 1
interface/explicit.go:60:14: error: type assertion only valid for interface types
label.go:64:9: error: reference to undefined label ‘go2’
label1.go:18:97: error: continue statement not within for
label1.go:22:97: error: continue statement not within for
label1.go:106:89: error: continue statement not within for
label1.go:108:26: error: invalid continue label ‘on’
label1.go:111:118: error: break statement not within for or switch or select
label1.go:113:23: error: invalid break label ‘dance’
map1.go:64:9: error: not enough arguments
map1.go:65:9: error: not enough arguments
map1.go:67:9: error: argument 1 must be a map
method2.go:36:11: error: reference to undefined field or method ‘val’
method2.go:37:11: error: reference to undefined field or method ‘val’
method2.go:41:12: error: method requires pointer (use ‘(*T).g’)
syntax/chan1.go:13:19: error: send statement used as value; use select for non-blocking send
syntax/chan1.go:17:11: error: send statement used as value; use select for non-blocking send
Change-Id: I98047b60a376e3d2788836300f7fcac3f2c285cb
Reviewed-on: https://go-review.googlesource.com/c/go/+/273527
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2020-11-26 20:26:02 +00:00
|
|
|
_ = 301[:] // ERROR "cannot slice|attempt to slice object that is not"
|
|
|
|
_ = 3.1[:] // ERROR "cannot slice|attempt to slice object that is not"
|
|
|
|
_ = true[:] // ERROR "cannot slice|attempt to slice object that is not"
|
2017-04-22 13:28:58 +00:00
|
|
|
|
2011-12-02 17:30:56 +00:00
|
|
|
// these are okay because they are slicing a pointer to an array
|
2011-12-02 19:13:12 +00:00
|
|
|
_ = (&[3]int{1, 2, 3})[:]
|
2011-12-02 17:30:56 +00:00
|
|
|
_ = mp[0][:]
|
|
|
|
_ = fp()[:]
|
2011-12-02 19:13:12 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
type T struct {
|
|
|
|
i int
|
|
|
|
f float64
|
|
|
|
s string
|
|
|
|
next *T
|
|
|
|
}
|
|
|
|
|
2017-04-22 13:28:58 +00:00
|
|
|
type TP *T
|
|
|
|
type Ti int
|
|
|
|
|
2011-12-02 19:13:12 +00:00
|
|
|
var (
|
|
|
|
_ = &T{0, 0, "", nil} // ok
|
2012-01-27 07:06:47 +00:00
|
|
|
_ = &T{i: 0, f: 0, s: "", next: {}} // ERROR "missing type in composite literal|omit types within composite literal"
|
|
|
|
_ = &T{0, 0, "", {}} // ERROR "missing type in composite literal|omit types within composite literal"
|
2021-05-29 19:54:10 +00:00
|
|
|
_ = TP{i: 0, f: 0, s: ""} // ERROR "invalid composite literal type TP"
|
test: match gofrontend error messages
These changes match the following gofrontend error messages:
blank1.go:16:1: error: may not define methods on non-local type
chan/perm.go:28:9: error: expected channel
chan/perm.go:29:11: error: left operand of ‘<-’ must be channel
chan/perm.go:69:9: error: argument must be channel
complit1.go:25:16: error: attempt to slice object that is not array, slice, or string
complit1.go:26:16: error: attempt to slice object that is not array, slice, or string
complit1.go:27:17: error: attempt to slice object that is not array, slice, or string
complit1.go:49:41: error: may only omit types within composite literals of slice, array, or map type
complit1.go:50:14: error: expected struct, slice, array, or map type for composite literal
convlit.go:24:9: error: invalid type conversion (cannot use type unsafe.Pointer as type string)
convlit.go:25:9: error: invalid type conversion (cannot use type unsafe.Pointer as type float64)
convlit.go:26:9: error: invalid type conversion (cannot use type unsafe.Pointer as type int)
ddd1.go:63:9: error: invalid use of ‘...’ calling non-variadic function
fixedbugs/bug176.go:12:18: error: index expression is not integer constant
fixedbugs/bug332.go:17:10: error: use of undefined type ‘T’
fixedbugs/issue4232.go:22:16: error: integer constant overflow
fixedbugs/issue4232.go:33:16: error: integer constant overflow
fixedbugs/issue4232.go:44:25: error: integer constant overflow
fixedbugs/issue4232.go:55:16: error: integer constant overflow
fixedbugs/issue4458.go:19:14: error: type has no method ‘foo’
fixedbugs/issue5172.go:24:14: error: too many expressions for struct
init.go:17:9: error: reference to undefined name ‘runtime’
initializerr.go:26:29: error: duplicate value for index 1
interface/explicit.go:60:14: error: type assertion only valid for interface types
label.go:64:9: error: reference to undefined label ‘go2’
label1.go:18:97: error: continue statement not within for
label1.go:22:97: error: continue statement not within for
label1.go:106:89: error: continue statement not within for
label1.go:108:26: error: invalid continue label ‘on’
label1.go:111:118: error: break statement not within for or switch or select
label1.go:113:23: error: invalid break label ‘dance’
map1.go:64:9: error: not enough arguments
map1.go:65:9: error: not enough arguments
map1.go:67:9: error: argument 1 must be a map
method2.go:36:11: error: reference to undefined field or method ‘val’
method2.go:37:11: error: reference to undefined field or method ‘val’
method2.go:41:12: error: method requires pointer (use ‘(*T).g’)
syntax/chan1.go:13:19: error: send statement used as value; use select for non-blocking send
syntax/chan1.go:17:11: error: send statement used as value; use select for non-blocking send
Change-Id: I98047b60a376e3d2788836300f7fcac3f2c285cb
Reviewed-on: https://go-review.googlesource.com/c/go/+/273527
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2020-11-26 20:26:02 +00:00
|
|
|
_ = &Ti{} // ERROR "invalid composite literal type Ti|expected.*type for composite literal"
|
2011-12-02 19:13:12 +00:00
|
|
|
)
|
2015-05-19 20:49:47 +00:00
|
|
|
|
|
|
|
type M map[T]T
|
|
|
|
|
|
|
|
var (
|
2021-05-29 19:54:10 +00:00
|
|
|
_ = M{{i: 1}: {i: 2}}
|
|
|
|
_ = M{T{i: 1}: {i: 2}}
|
|
|
|
_ = M{{i: 1}: T{i: 2}}
|
|
|
|
_ = M{T{i: 1}: T{i: 2}}
|
2015-05-19 20:49:47 +00:00
|
|
|
)
|
|
|
|
|
2021-05-29 19:54:10 +00:00
|
|
|
type S struct{ s [1]*M1 }
|
2015-05-19 20:49:47 +00:00
|
|
|
type M1 map[S]int
|
|
|
|
|
2021-05-29 19:54:10 +00:00
|
|
|
var _ = M1{{s: [1]*M1{&M1{{}: 1}}}: 2}
|