update build and lint rules

.github/workflows/ci.yml

@@ -13,28 +13,12 @@ jobs:
         os: [ubuntu-latest, windows-latest, macOS-latest]
     steps:
     - name: Checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
     - name: Install rust
-      uses: actions-rs/toolchain@v1
+      uses: dtolnay/rust-toolchain@master
       with:
         toolchain: ${{ matrix.rust }}
-        profile: minimal
-        override: true
     - name: Install cargo-make
-      uses: actions-rs/cargo@v1
+      run: cargo install --debug cargo-make
-      with:
-        command: install
-        args: --debug cargo-make
     - name: Run CI
-      if: matrix.rust != 'nightly'
+      run: cargo make --no-workspace workspace-ci-flow
-      uses: actions-rs/cargo@v1
-      with:
-        command: make
-        args: --no-workspace workspace-ci-flow
-    - name: Run CI (Allow Failures)
-      if: matrix.rust == 'nightly'
-      continue-on-error: true
-      uses: actions-rs/cargo@v1
-      with:
-        command: make
-        args: --no-workspace workspace-ci-flow

duckscript/src/lib.rs

@@ -1,11 +1,14 @@
 #![deny(
     absolute_paths_not_starting_with_crate,
     ambiguous_associated_items,
+    ambiguous_glob_imports,
     ambiguous_glob_reexports,
+    ambiguous_wide_pointer_comparisons,
     anonymous_parameters,
     arithmetic_overflow,
     array_into_iter,
     asm_sub_register,
+    async_fn_in_trait,
     bad_asm_style,
     bindings_with_variant_name,
     break_with_label_and_loop,
@@ -17,6 +20,7 @@
     confusable_idents,
     const_evaluatable_unchecked,
     const_item_mutation,
+    const_patterns_without_partial_eq,
     dead_code,
     deprecated,
     deprecated_cfg_attr_crate_type_name,
@@ -29,6 +33,7 @@
     dropping_references,
     duplicate_macro_attributes,
     dyn_drop,
+    elided_lifetimes_in_associated_constant,
     ellipsis_inclusive_range_patterns,
     enum_intrinsics_non_enums,
     explicit_outlives_requirements,
@@ -39,9 +44,9 @@
     forgetting_copy_types,
     forgetting_references,
     function_item_references,
+    hidden_glob_reexports,
     ill_formed_attribute_input,
     illegal_floating_point_literal_pattern,
-    implied_bounds_entailment,
     improper_ctypes,
     improper_ctypes_definitions,
     incomplete_features,
@@ -49,10 +54,14 @@
     indirect_structural_match,
     ineffective_unstable_trait_impl,
     inline_no_sanitize,
-    invalid_alignment,
+    internal_features,
     invalid_atomic_ordering,
     invalid_doc_attributes,
+    invalid_from_utf8,
+    invalid_from_utf8_unchecked,
     invalid_macro_export_arguments,
+    invalid_nan_comparisons,
+    invalid_reference_casting,
     invalid_type_param_default,
     invalid_value,
     irrefutable_let_patterns,
@@ -62,6 +71,7 @@
     legacy_derive_helpers,
     let_underscore_drop,
     let_underscore_lock,
+    long_running_const_eval,
     macro_expanded_macro_exports_accessed_by_absolute_paths,
     map_unit_fn,
     meta_variable_misuse,
@@ -90,11 +100,13 @@
     path_statements,
     patterns_in_fns_without_body,
     pointer_structural_match,
-    private_in_public,
+    private_bounds,
+    private_interfaces,
     proc_macro_back_compat,
     proc_macro_derive_resolution_fallback,
     pub_use_of_private_extern_crate,
     redundant_semicolons,
+    refining_impl_trait,
     repr_transparent_external_private_fields,
     rust_2021_incompatible_closure_captures,
     rust_2021_incompatible_or_patterns,
@@ -104,6 +116,7 @@
     soft_unstable,
     special_module_name,
     stable_features,
+    static_mut_ref,
     suspicious_auto_trait_impls,
     suspicious_double_ref_op,
     temporary_cstring_as_ptr,
@@ -118,9 +131,11 @@
     unconditional_panic,
     unconditional_recursion,
     undefined_naked_function_abi,
+    undropped_manually_drops,
     unexpected_cfgs,
     ungated_async_fn_track_caller,
     uninhabited_static,
+    unit_bindings,
     unknown_crate_types,
     unnameable_test_items,
     unreachable_code,
@@ -135,6 +150,7 @@
     unused_allocation,
     unused_assignments,
     unused_assignments,
+    unused_associated_type_bounds,
     unused_attributes,
     unused_braces,
     unused_comparisons,
@@ -152,12 +168,13 @@
     unused_mut,
     unused_parens,
     unused_qualifications,
-    unused_tuple_struct_fields,
     unused_unsafe,
     unused_variables,
     useless_deprecated,
+    useless_ptr_null_checks,
     where_clauses_object_safety,
-    while_true
+    while_true,
+    writes_through_immutable_pointer
 )]
 #![warn(macro_use_extern_crate, unknown_lints)]
 #![allow(

duckscript_cli/src/main.rs

@@ -1,11 +1,14 @@
 #![deny(
     absolute_paths_not_starting_with_crate,
     ambiguous_associated_items,
+    ambiguous_glob_imports,
     ambiguous_glob_reexports,
+    ambiguous_wide_pointer_comparisons,
     anonymous_parameters,
     arithmetic_overflow,
     array_into_iter,
     asm_sub_register,
+    async_fn_in_trait,
     bad_asm_style,
     bindings_with_variant_name,
     break_with_label_and_loop,
@@ -17,6 +20,7 @@
     confusable_idents,
     const_evaluatable_unchecked,
     const_item_mutation,
+    const_patterns_without_partial_eq,
     dead_code,
     deprecated,
     deprecated_cfg_attr_crate_type_name,
@@ -29,6 +33,7 @@
     dropping_references,
     duplicate_macro_attributes,
     dyn_drop,
+    elided_lifetimes_in_associated_constant,
     ellipsis_inclusive_range_patterns,
     enum_intrinsics_non_enums,
     explicit_outlives_requirements,
@@ -39,9 +44,9 @@
     forgetting_copy_types,
     forgetting_references,
     function_item_references,
+    hidden_glob_reexports,
     ill_formed_attribute_input,
     illegal_floating_point_literal_pattern,
-    implied_bounds_entailment,
     improper_ctypes,
     improper_ctypes_definitions,
     incomplete_features,
@@ -49,10 +54,14 @@
     indirect_structural_match,
     ineffective_unstable_trait_impl,
     inline_no_sanitize,
-    invalid_alignment,
+    internal_features,
     invalid_atomic_ordering,
     invalid_doc_attributes,
+    invalid_from_utf8,
+    invalid_from_utf8_unchecked,
     invalid_macro_export_arguments,
+    invalid_nan_comparisons,
+    invalid_reference_casting,
     invalid_type_param_default,
     invalid_value,
     irrefutable_let_patterns,
@@ -62,6 +71,7 @@
     legacy_derive_helpers,
     let_underscore_drop,
     let_underscore_lock,
+    long_running_const_eval,
     macro_expanded_macro_exports_accessed_by_absolute_paths,
     map_unit_fn,
     meta_variable_misuse,
@@ -90,11 +100,13 @@
     path_statements,
     patterns_in_fns_without_body,
     pointer_structural_match,
-    private_in_public,
+    private_bounds,
+    private_interfaces,
     proc_macro_back_compat,
     proc_macro_derive_resolution_fallback,
     pub_use_of_private_extern_crate,
     redundant_semicolons,
+    refining_impl_trait,
     repr_transparent_external_private_fields,
     rust_2021_incompatible_closure_captures,
     rust_2021_incompatible_or_patterns,
@@ -104,6 +116,7 @@
     soft_unstable,
     special_module_name,
     stable_features,
+    static_mut_ref,
     suspicious_auto_trait_impls,
     suspicious_double_ref_op,
     temporary_cstring_as_ptr,
@@ -118,9 +131,11 @@
     unconditional_panic,
     unconditional_recursion,
     undefined_naked_function_abi,
+    undropped_manually_drops,
     unexpected_cfgs,
     ungated_async_fn_track_caller,
     uninhabited_static,
+    unit_bindings,
     unknown_crate_types,
     unnameable_test_items,
     unreachable_code,
@@ -135,6 +150,7 @@
     unused_allocation,
     unused_assignments,
     unused_assignments,
+    unused_associated_type_bounds,
     unused_attributes,
     unused_braces,
     unused_comparisons,
@@ -152,12 +168,13 @@
     unused_mut,
     unused_parens,
     unused_qualifications,
-    unused_tuple_struct_fields,
     unused_unsafe,
     unused_variables,
     useless_deprecated,
+    useless_ptr_null_checks,
     where_clauses_object_safety,
-    while_true
+    while_true,
+    writes_through_immutable_pointer
 )]
 #![warn(macro_use_extern_crate, unknown_lints)]
 #![allow(

duckscript_sdk/Makefile.toml

@@ -25,11 +25,13 @@ alias = "test-scripts"
 
 [tasks.test-script]
 cwd = ".."
+install_crate = false
 command = "cargo"
 args = ["make", "--no-workspace", "test-script", "${@}"]
 
 [tasks.test-scripts]
 cwd = ".."
+install_crate = false
 command = "cargo"
 args = ["make", "--no-workspace", "test-scripts"]
 

duckscript_sdk/src/lib.rs

@@ -1,11 +1,14 @@
 #![deny(
     absolute_paths_not_starting_with_crate,
     ambiguous_associated_items,
+    ambiguous_glob_imports,
     ambiguous_glob_reexports,
+    ambiguous_wide_pointer_comparisons,
     anonymous_parameters,
     arithmetic_overflow,
     array_into_iter,
     asm_sub_register,
+    async_fn_in_trait,
     bad_asm_style,
     bindings_with_variant_name,
     break_with_label_and_loop,
@@ -17,6 +20,7 @@
     confusable_idents,
     const_evaluatable_unchecked,
     const_item_mutation,
+    const_patterns_without_partial_eq,
     dead_code,
     deprecated,
     deprecated_cfg_attr_crate_type_name,
@@ -29,6 +33,7 @@
     dropping_references,
     duplicate_macro_attributes,
     dyn_drop,
+    elided_lifetimes_in_associated_constant,
     ellipsis_inclusive_range_patterns,
     enum_intrinsics_non_enums,
     explicit_outlives_requirements,
@@ -39,9 +44,9 @@
     forgetting_copy_types,
     forgetting_references,
     function_item_references,
+    hidden_glob_reexports,
     ill_formed_attribute_input,
     illegal_floating_point_literal_pattern,
-    implied_bounds_entailment,
     improper_ctypes,
     improper_ctypes_definitions,
     incomplete_features,
@@ -49,10 +54,14 @@
     indirect_structural_match,
     ineffective_unstable_trait_impl,
     inline_no_sanitize,
-    invalid_alignment,
+    internal_features,
     invalid_atomic_ordering,
     invalid_doc_attributes,
+    invalid_from_utf8,
+    invalid_from_utf8_unchecked,
     invalid_macro_export_arguments,
+    invalid_nan_comparisons,
+    invalid_reference_casting,
     invalid_type_param_default,
     invalid_value,
     irrefutable_let_patterns,
@@ -62,6 +71,7 @@
     legacy_derive_helpers,
     let_underscore_drop,
     let_underscore_lock,
+    long_running_const_eval,
     macro_expanded_macro_exports_accessed_by_absolute_paths,
     map_unit_fn,
     meta_variable_misuse,
@@ -90,11 +100,13 @@
     path_statements,
     patterns_in_fns_without_body,
     pointer_structural_match,
-    private_in_public,
+    private_bounds,
+    private_interfaces,
     proc_macro_back_compat,
     proc_macro_derive_resolution_fallback,
     pub_use_of_private_extern_crate,
     redundant_semicolons,
+    refining_impl_trait,
     repr_transparent_external_private_fields,
     rust_2021_incompatible_closure_captures,
     rust_2021_incompatible_or_patterns,
@@ -104,6 +116,7 @@
     soft_unstable,
     special_module_name,
     stable_features,
+    static_mut_ref,
     suspicious_auto_trait_impls,
     suspicious_double_ref_op,
     temporary_cstring_as_ptr,
@@ -118,9 +131,11 @@
     unconditional_panic,
     unconditional_recursion,
     undefined_naked_function_abi,
+    undropped_manually_drops,
     unexpected_cfgs,
     ungated_async_fn_track_caller,
     uninhabited_static,
+    unit_bindings,
     unknown_crate_types,
     unnameable_test_items,
     unreachable_code,
@@ -135,6 +150,7 @@
     unused_allocation,
     unused_assignments,
     unused_assignments,
+    unused_associated_type_bounds,
     unused_attributes,
     unused_braces,
     unused_comparisons,
@@ -152,12 +168,13 @@
     unused_mut,
     unused_parens,
     unused_qualifications,
-    unused_tuple_struct_fields,
     unused_unsafe,
     unused_variables,
     useless_deprecated,
+    useless_ptr_null_checks,
     where_clauses_object_safety,
-    while_true
+    while_true,
+    writes_through_immutable_pointer
 )]
 #![warn(macro_use_extern_crate, unknown_lints)]
 #![allow(