mirror of
https://github.com/dart-lang/sdk
synced 2024-09-05 00:13:50 +00:00
fcbf5341f0
logRecords is expected to be of type dict, but the fallback value was previously set to [] (type list). This CL changes the fallback values to an empty dict. It also uses the builtin dict.get() to handle to fallback instead of manually doing so. Note: This CL will not make the bot go green. It will change it from purple (infra failure due to crash) to red since there are tests that are legitimately failing. Bug: https://github.com/dart-lang/sdk/issues/42625 Cq-Include-Trybots: dart/try:vm-dartkb-linux-release-x64-abi-try Change-Id: I12ad7688719039566cd16e128997f0f8efc60a69 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153600 Commit-Queue: Clement Skau <cskau@google.com> Auto-Submit: Clement Skau <cskau@google.com> Reviewed-by: Daco Harkes <dacoharkes@google.com> |
||
|---|---|---|
| .. | ||
| abiversions | ||
| android | ||
| apps/update_homebrew | ||
| bots | ||
| buildtools | ||
| dart2js | ||
| dom | ||
| linux_dist_support/debian | ||
| migration | ||
| patches | ||
| sdks | ||
| spec_parser | ||
| test_generators | ||
| testing | ||
| .gitignore | ||
| 3xhead_flutter_hooks.sh | ||
| addlatexhash.dart | ||
| build.py | ||
| canary.dart | ||
| clean_output_directory.py | ||
| copy_dart.py | ||
| copy_tree.py | ||
| create_debian_chroot.sh | ||
| create_debian_packages.py | ||
| create_pkg_manifest.py | ||
| create_tarball.py | ||
| create_timestamp_file.py | ||
| diff_results.dart | ||
| download_abi_dills.py | ||
| download_chromium_sysroot.sh | ||
| download_latest_dev_sdk.py | ||
| execute_recorded_testcases.py | ||
| experimental_features.yaml | ||
| FAKE_COMMITS | ||
| find_depot_tools.py | ||
| gen_fuchsia_test_manifest.py | ||
| generate_buildfiles.py | ||
| generate_idefiles.py | ||
| generate_package_config.dart | ||
| gn.py | ||
| gn_helpers.py | ||
| line_doc_comments.dart | ||
| list_dart_files.py | ||
| list_files.py | ||
| make_bundle_unittest.py | ||
| make_version.py | ||
| minidump.py | ||
| only_in_release_mode.py | ||
| presubmit.sh | ||
| promote.py | ||
| publish_pkg.py | ||
| revert.py | ||
| run_abi_tests.py | ||
| run_debian_build.sh | ||
| run_offsets_extractor.sh | ||
| safari_factory_reset.py | ||
| set_ia32_sysroot.sh | ||
| set_x64_sysroot.sh | ||
| spec_parse.py | ||
| task_kill.py | ||
| test.dart | ||
| test.py | ||
| upload_abi_dills.sh | ||
| utils.py | ||
| validate_test_matrix.dart | ||
| VERSION | ||
| write_dartdoc_options_file.py | ||
| write_revision_file.py | ||
| write_version_file.py | ||
| yaml2json.dart | ||
| yaml2json.py | ||