mirror of
https://github.com/dart-lang/sdk
synced 2024-09-05 16:41:07 +00:00
![Vyacheslav Egorov](/assets/img/avatar_default.png)
Android is based on Linux, so most of the files were identical sans some subtle discrepancies caused by drift over time. This discrepancies were making code base harder to maintain and in fact were hiding bugs. For example, on Android eventhandler's implementation of timers which relied on passing timeout to `epoll_wait` contained a bug which was not present on Linux which used `timerfd` instead. TEST=ci and manual testing of Flutter app on Android device Fixes https://github.com/dart-lang/sdk/issues/54868 Cq-Include-Trybots: luci.dart.try:vm-aot-android-release-arm64c-try,vm-aot-android-release-arm_x64-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-ffi-android-product-arm-try,vm-ffi-android-product-arm64c-try,vm-ffi-android-release-arm-try,vm-ffi-android-release-arm64c-try Bug: b/311165013 Change-Id: Ia166f69c14177ec34160805a0983eafee8ea65f6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/350923 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Slava Egorov <vegorov@google.com>
93 lines
2.4 KiB
C++
93 lines
2.4 KiB
C++
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "platform/globals.h"
|
|
#if defined(DART_HOST_OS_LINUX) || defined(DART_HOST_OS_ANDROID)
|
|
|
|
#include "bin/sync_socket.h"
|
|
|
|
#include <errno.h> // NOLINT
|
|
|
|
#include "bin/fdutils.h"
|
|
#include "bin/socket_base.h"
|
|
#include "platform/signal_blocker.h"
|
|
|
|
namespace dart {
|
|
namespace bin {
|
|
|
|
bool SynchronousSocket::Initialize() {
|
|
// Nothing to do on Linux.
|
|
return true;
|
|
}
|
|
|
|
static intptr_t Create(const RawAddr& addr) {
|
|
intptr_t fd;
|
|
intptr_t type = SOCK_STREAM | SOCK_CLOEXEC;
|
|
fd = NO_RETRY_EXPECTED(socket(addr.ss.ss_family, type, 0));
|
|
if (fd < 0) {
|
|
return -1;
|
|
}
|
|
return fd;
|
|
}
|
|
|
|
static intptr_t Connect(intptr_t fd, const RawAddr& addr) {
|
|
intptr_t result = TEMP_FAILURE_RETRY(
|
|
connect(fd, &addr.addr, SocketAddress::GetAddrLength(addr)));
|
|
if (result == 0) {
|
|
return fd;
|
|
}
|
|
ASSERT(errno != EINPROGRESS);
|
|
FDUtils::SaveErrorAndClose(fd);
|
|
return -1;
|
|
}
|
|
|
|
intptr_t SynchronousSocket::CreateConnect(const RawAddr& addr) {
|
|
intptr_t fd = Create(addr);
|
|
if (fd < 0) {
|
|
return fd;
|
|
}
|
|
return Connect(fd, addr);
|
|
}
|
|
|
|
intptr_t SynchronousSocket::Available(intptr_t fd) {
|
|
return SocketBase::Available(fd);
|
|
}
|
|
|
|
intptr_t SynchronousSocket::GetPort(intptr_t fd) {
|
|
return SocketBase::GetPort(fd);
|
|
}
|
|
|
|
SocketAddress* SynchronousSocket::GetRemotePeer(intptr_t fd, intptr_t* port) {
|
|
return SocketBase::GetRemotePeer(fd, port);
|
|
}
|
|
|
|
intptr_t SynchronousSocket::Read(intptr_t fd,
|
|
void* buffer,
|
|
intptr_t num_bytes) {
|
|
return SocketBase::Read(fd, buffer, num_bytes, SocketBase::kSync);
|
|
}
|
|
|
|
intptr_t SynchronousSocket::Write(intptr_t fd,
|
|
const void* buffer,
|
|
intptr_t num_bytes) {
|
|
return SocketBase::Write(fd, buffer, num_bytes, SocketBase::kSync);
|
|
}
|
|
|
|
void SynchronousSocket::ShutdownRead(intptr_t fd) {
|
|
VOID_NO_RETRY_EXPECTED(shutdown(fd, SHUT_RD));
|
|
}
|
|
|
|
void SynchronousSocket::ShutdownWrite(intptr_t fd) {
|
|
VOID_NO_RETRY_EXPECTED(shutdown(fd, SHUT_WR));
|
|
}
|
|
|
|
void SynchronousSocket::Close(intptr_t fd) {
|
|
return SocketBase::Close(fd);
|
|
}
|
|
|
|
} // namespace bin
|
|
} // namespace dart
|
|
|
|
#endif // defined(DART_HOST_OS_LINUX) || defined(DART_HOST_OS_ANDROID)
|