mirror of
https://github.com/dart-lang/sdk
synced 2024-07-19 20:17:27 +00:00
6011ba67b3
This is a reland of commit4cd9c9c666This will be relanded without changes because we discussed the .proto definition package name clashing problem with the Dart in google3 team, and we have decided that the best solution is to ignore the checked in .proto files in google3 builds. TEST=Recorded traces with the Perfetto file recorder and explored them in Perfetto's trace viewer, CI Original change's description: > Reland "[VM] Begin supporting Perfetto file recorder" > > This is a reland of commit7424295ce9> > The differences between this reland and the original CL are: now the > Perfetto file recorder does not get built in PRODUCT builds, and it does > not get built unless the SUPPORT_PERFETTO macro is defined. > > TEST=Recorded traces with the Perfetto file recorder and explored them > in Perfetto's trace viewer, CI > > Original change's description: > > [VM] Begin supporting Perfetto file recorder > > > > This CL adds the `TimelineEventPerfettoFileRecorder` class, which is a > > timeline recorder that writes a trace to file in Perfetto's proto > > format. This CL supports the recording of all types of timeline events > > except flow events. Support for flow events will be added in a future > > CL. > > > > TEST=Recorded traces with the Perfetto file recorder and explored them > > in Perfetto's trace viewer, CI > > > > Change-Id: Iaa2051e536589a473c5e15f9de9bb9c251f13d38 > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278942 > > Reviewed-by: Ben Konyi <bkonyi@google.com> > > Commit-Queue: Derek Xu <derekx@google.com> > > Change-Id: I8713f704b5fbeed5f1231012bce8a32aaf566ae4 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286020 > Reviewed-by: Ben Konyi <bkonyi@google.com> > Commit-Queue: Derek Xu <derekx@google.com> Change-Id: Ia97ef1f0fe73e76c7022623b9ae7e21a4ea73a46 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295804 Commit-Queue: Derek Xu <derekx@google.com> Reviewed-by: Ben Konyi <bkonyi@google.com>
86 lines
3.3 KiB
Python
86 lines
3.3 KiB
Python
#!/usr/bin/env python3
|
|
# Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
|
|
# for details. All rights reserved. Use of this source code is governed by a
|
|
# BSD-style license that can be found in the LICENSE file.
|
|
|
|
import os
|
|
import cpplint
|
|
import re
|
|
|
|
USE_PYTHON3 = True
|
|
|
|
# memcpy does not handle overlapping memory regions. Even though this
|
|
# is well documented it seems to be used in error quite often. To avoid
|
|
# problems we disallow the direct use of memcpy. The exceptions are in
|
|
# third-party code and in platform/globals.h which uses it to implement
|
|
# bit_cast and bit_copy.
|
|
def CheckMemcpy(filename):
|
|
if filename.endswith(os.path.join('platform', 'globals.h')) or \
|
|
filename.find('third_party') != -1:
|
|
return 0
|
|
fh = open(filename, 'r')
|
|
content = fh.read()
|
|
match = re.search('\\bmemcpy\\b', content)
|
|
if match:
|
|
offset = match.start()
|
|
end_of_line = content.index('\n', offset)
|
|
# We allow explicit use of memcpy with an opt-in via NOLINT
|
|
if 'NOLINT' not in content[offset:end_of_line]:
|
|
line_number = content[0:match.start()].count('\n') + 1
|
|
print("%s:%d: use of memcpy is forbidden" % (filename, line_number))
|
|
return 1
|
|
return 0
|
|
|
|
|
|
def RunLint(input_api, output_api):
|
|
result = []
|
|
cpplint._cpplint_state.ResetErrorCounts()
|
|
memcpy_match_count = 0
|
|
# Find all .cc and .h files in the change list.
|
|
for git_file in input_api.AffectedTextFiles():
|
|
filename = git_file.AbsoluteLocalPath()
|
|
if filename.endswith('.cc') or (
|
|
# cpplint complains about the style of #ifndefs in our .pbzero.h
|
|
# files, but they are generated by the protozero compiler, so we
|
|
# can't fix this.
|
|
not filename.endswith('.pbzero.h') and filename.endswith('.h')):
|
|
# Run cpplint on the file.
|
|
cpplint.ProcessFile(filename, 1)
|
|
# Check for memcpy use.
|
|
memcpy_match_count += CheckMemcpy(filename)
|
|
|
|
# Report a presubmit error if any of the files had an error.
|
|
if cpplint._cpplint_state.error_count > 0 or memcpy_match_count > 0:
|
|
result = [output_api.PresubmitError('Failed cpplint check.')]
|
|
return result
|
|
|
|
|
|
def CheckGn(input_api, output_api):
|
|
return input_api.canned_checks.CheckGNFormatted(input_api, output_api)
|
|
|
|
|
|
def CheckFormatted(input_api, output_api):
|
|
|
|
def convert_warning_to_error(presubmit_result):
|
|
if not presubmit_result.fatal:
|
|
# Convert this warning to an error.
|
|
result_json = presubmit_result.json_format()
|
|
return output_api.PresubmitError(
|
|
message=result_json['message'],
|
|
items=result_json['items'],
|
|
long_text=result_json['long_text'])
|
|
return presubmit_result
|
|
|
|
results = input_api.canned_checks.CheckPatchFormatted(input_api, output_api)
|
|
return [convert_warning_to_error(r) for r in results]
|
|
|
|
|
|
def CheckChangeOnUpload(input_api, output_api):
|
|
return (RunLint(input_api, output_api) + CheckGn(input_api, output_api) +
|
|
CheckFormatted(input_api, output_api))
|
|
|
|
|
|
def CheckChangeOnCommit(input_api, output_api):
|
|
return (RunLint(input_api, output_api) + CheckGn(input_api, output_api) +
|
|
CheckFormatted(input_api, output_api))
|