f3740c96e8
This code
```
import 'dart:isolate';
Future<void> main([List<String> arguments = const []]) async {
await something();
print("After the call!");
if (1+1==2) throw "This will be swallowed";
print("This will never be printed.");
}
Future<void> something() async {
Isolate.current.setErrorsFatal(false);
}
```
prints
```
$ out/ReleaseX64/dart pkg/front_end/test/fasta/hmm.dart
After the call!
$ echo $?
0
```
I.e. it dies silently, swallowing the throw and has a 0 exit code.
Using package:testing (and having it run at least one thing), it
previously did this so that if anything crashed, say, in user code
after the run (or maybe even some places inside package:testing?) it
would just swallow the error and leave a 0 exit code.
This CL sets the errors fatal thing to true (which must be the default)
causing the normal behaviour of it not swallowing any throws.
Change-Id: I9850bbf504e172cc4077e5e17265833ef58dfe90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/350321
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
|
||
|---|---|---|
| .. | ||
| _fe_analyzer_shared | ||
| _js_interop_checks | ||
| analysis_server | ||
| analysis_server_client | ||
| analyzer | ||
| analyzer_cli | ||
| analyzer_plugin | ||
| analyzer_utilities | ||
| async_helper | ||
| bisect_dart | ||
| build_integration | ||
| compiler | ||
| dart_internal | ||
| dart_service_protocol_shared | ||
| dart2js_info | ||
| dart2js_runtime_metrics | ||
| dart2js_tools | ||
| dart2native | ||
| dart2wasm | ||
| dartdev | ||
| dds | ||
| dds_service_extensions | ||
| dev_compiler | ||
| dtd | ||
| dtd_impl | ||
| expect | ||
| front_end | ||
| frontend_server | ||
| heap_snapshot | ||
| js | ||
| js_ast | ||
| js_runtime | ||
| js_shared | ||
| kernel | ||
| language_versioning_2_12_test | ||
| linter | ||
| meta | ||
| mmap | ||
| modular_test | ||
| native_stack_traces | ||
| scrape | ||
| smith | ||
| sourcemap_testing | ||
| status_file | ||
| telemetry | ||
| test_runner | ||
| testing | ||
| vm | ||
| vm_service | ||
| vm_service_interface | ||
| vm_service_protos | ||
| vm_snapshot_analysis | ||
| wasm_builder | ||
| .gitignore | ||
| analysis_options.yaml | ||
| BUILD.gn | ||
| OWNERS | ||
| pkg.dart | ||
| pkg.status | ||
| README.md | ||
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency