mirror of
https://github.com/dart-lang/sdk
synced 2024-10-14 17:59:39 +00:00
edeac698c2
This change is almost trivial. The closure is stored on the callback's RawReceivePort, not in the VM. So we can basically just remove the CFE check and it pretty much works. The only problem is that we can't set function.FfiCallbackTarget anymore, so most of the CL is dealing with that. A few places were deciding whether an FFI trampoline was a call or a callback based on whether function.FfiCallbackTarget() was null. But now the target will be null for async callbacks. So instead I've added a new value to the FfiCallbackKind enum (and renamed it), and changed those checks. Sync callback closures will be a separate CL, because they're more complicated. Bug: https://github.com/dart-lang/sdk/issues/52689 Change-Id: I8e5dfb557362e679f66195b735c3c382e6792840 TEST=async_void_function_callbacks_test.dart Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316160 Commit-Queue: Liam Appelbe <liama@google.com> Reviewed-by: Daco Harkes <dacoharkes@google.com> |
||
|---|---|---|
| .. | ||
| _http | ||
| _internal | ||
| _wasm | ||
| async | ||
| cli | ||
| collection | ||
| convert | ||
| core | ||
| developer | ||
| ffi | ||
| html | ||
| indexed_db/dart2js | ||
| internal | ||
| io | ||
| isolate | ||
| js | ||
| js_interop | ||
| js_interop_unsafe | ||
| js_util | ||
| math | ||
| mirrors | ||
| svg/dart2js | ||
| typed_data | ||
| vmservice | ||
| web_audio/dart2js | ||
| web_gl/dart2js | ||
| web_sql/dart2js | ||
| analysis_options.yaml | ||
| libraries.json | ||
| libraries.yaml | ||
| PRESUBMIT.py | ||
| vmservice_libraries.json | ||
| vmservice_libraries.yaml | ||