mirror of
https://github.com/dart-lang/sdk
synced 2024-10-01 18:04:54 +00:00
edde575dcd
Adds a new SDK hash to kernels and the VM which is optionally checked to verify kernels are built for the same SDK as the VM. This helps catch incompatibilities that are currently causing subtle bugs and (not so subtle) crashes. The SDK hash is encoded in kernels as a new field in components. The hash is derived from the 10 byte git short hash. This new check can be disabled via: tools/gn.py ... --no-verify-sdk-hash This CL bumps the min. (and max.) supported kernel format version, making the VM backwards incompatible from this point back. Bug: https://github.com/dart-lang/sdk/issues/41802 Change-Id: I3cbb2d481239ee64dafdaa0e4aac36c80281931b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150343 Commit-Queue: Clement Skau <cskau@google.com> Reviewed-by: Jens Johansen <jensj@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
41 lines
1.5 KiB
Plaintext
41 lines
1.5 KiB
Plaintext
# Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
|
|
# for details. All rights reserved. Use of this source code is governed by a
|
|
# BSD-style license that can be found in the LICENSE file.
|
|
|
|
_dart_root = get_path_info(".", "abspath")
|
|
|
|
declare_args() {
|
|
# Absolute path to the .git folder.
|
|
#
|
|
# This is used in rules that need to refer to `.git/logs/HEAD` to include
|
|
# a hash in the version string. By default the folder is `.git`, but we define
|
|
# it as an argument so it can be overriden by users of `git-worktree` (See
|
|
# Issue #33619).
|
|
#
|
|
# When using git-worktree, you can add
|
|
#
|
|
# default_git_folder = "/path/to/main/git/repo/.git/worktrees/name/"
|
|
#
|
|
# to out/ReleaseX64/args.gn. The path above can be extracted from the `.git`
|
|
# file under the git worktree folder.
|
|
default_git_folder = "$_dart_root/.git"
|
|
|
|
# Whether to enable the SDK hash check that will prevent loading a kernel
|
|
# into a VM which was built with a different SDK.
|
|
verify_sdk_hash = true
|
|
}
|
|
|
|
# The SDK hash to build into VM and kernels.
|
|
# The value 0000000000 signifies no hash is set, which will disable the check.
|
|
if (verify_sdk_hash) {
|
|
sdk_hash = exec_script("$_dart_root/tools/make_version.py",
|
|
[ "--format={{GIT_HASH}}" ],
|
|
"trim string",
|
|
[
|
|
"$_dart_root/tools/VERSION",
|
|
"$_dart_root/tools/utils.py",
|
|
])
|
|
} else {
|
|
sdk_hash = "0000000000"
|
|
}
|