Mike Fairhurst ec58f5646a Revert "Make void a static warning to use almost everywhere." ... This reverts commit 09eed74a8a. Reason for revert: Too much SDK code is not yet compliant. Original change's description: > Make `void` a static warning to use almost everywhere. > > Changed the hint to a StaticWarningCode, since that's the new spec'd > error type and the hint is no longer needed. > > Added a new set of methods to test the cases. > > Didn't try to solve the problem generally ("all usages except ... are > errors" means it easier, in theory, to make a ReportVoidExpressions > style visitor that catches absolutely all types) because most of the > work is actually about suppressing errors that are no longer needed. > Ie, from NO_SUCH_METHOD to USAGE_OF_VOID_RESULT which means we have to > put the void handling logic into each AST method specially anyway. > > Some redundant tests removed. > > Don't flag: ternaries, void -> void assignments, void returns in > dynamic. > > Change-Id: Ief8035dcfe582b36b6372180ddcf4e453d320d9c > Reviewed-on: https://dart-review.googlesource.com/37441 > Commit-Queue: Mike Fairhurst <mfairhurst@google.com> > Reviewed-by: Leaf Petersen <leafp@google.com> TBR=leafp@google.com,scheglov@google.com,mfairhurst@google.com Change-Id: I13ee4c6939468d35506779ade637a040833632f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/39848 Reviewed-by: Mike Fairhurst <mfairhurst@google.com> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>		2018-02-07 22:32:51 +00:00
..
lib	Revert "Make void a static warning to use almost everywhere."	2018-02-07 22:32:51 +00:00
test	Add Expect.notIdentical and Expect.allDistinct to package:expect.	2018-01-12 09:33:16 +00:00
LICENSE	pkg/unittest: added LICENSE	2014-01-13 18:07:45 +00:00
pubspec.yaml	Remove version from unpublished packages	2017-12-19 18:26:05 +00:00