languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-04 16:03:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
dart-sdk/utils
History
Alexander Markov ea7348c5f0 Revert "[vm/bytecode] Switch kernel service dill to bytecode if building Dart SDK with --bytecode" 
This reverts commit beee442625.

Reason for revert: StackOverflow on language_2/deep_nesting_expression_test/01 in interpreted mode.

Original change's description:
> [vm/bytecode] Switch kernel service dill to bytecode if building Dart SDK with --bytecode
> 
> Temporary setting of FLAG_enable_interpreter is avoided in the VM unit tests as
> this flag is global and used by kernel service isolate while running tests.
> Flipping this flag causes assertion failures in kernel isolate's background compiler
> or infinite loop between LazyCompile stub and CompileFunction as AttachBytecode
> doesn't set entry point to InterpretCall.
> 
> The less intrusive way to ensure compilation of functions in unit tests is to set
> FLAG_compilation_counter_threshold to 0.
> 
> Change-Id: Ia46ff8d03d66ab8b147b9d89336548c4a9c29f5d
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113123
> Commit-Queue: Alexander Markov <alexmarkov@google.com>
> Reviewed-by: Régis Crelier <regis@google.com>

TBR=rmacnak@google.com,alexmarkov@google.com,regis@google.com

Change-Id: I67cd03a56f9a2d29aa6597d38779e77ca3a16b18
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113480
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2019-08-16 22:39:52 +00:00
..
analysis_server [gen_snapshot] Restore support for --snapshot_kind=vm-aot-assembly; update docs. 2018-09-28 21:43:04 +00:00
bazel [bazel] Fix serialization when not doing summary 2019-08-15 16:31:30 +00:00
compiler [tools] Remove patch_sdk tool which is no longer used. 2019-06-25 11:46:37 +00:00
dartanalyzer [vm] Revert 1db1ac4863. 2019-05-08 23:52:29 +00:00
dartdevc [dartdevc] fix sdk source map paths 2019-07-15 16:11:04 +00:00
dartdoc [VM/SDK] Switch kernel isolate to run in Dart 2 mode 2018-08-21 20:28:06 +00:00
dartfmt [VM/SDK] Switch kernel isolate to run in Dart 2 mode 2018-08-21 20:28:06 +00:00
gen_kernel [SDK] Adds build targets, wrappers and SDK builds for Dart AOT. 2019-04-05 13:23:44 +00:00
kernel-service Revert "[vm/bytecode] Switch kernel service dill to bytecode if building Dart SDK with --bytecode" 2019-08-16 22:39:52 +00:00
peg Spelling fixes e to i. 2017-06-24 13:41:39 +02:00
pub [VM/SDK] Switch kernel isolate to run in Dart 2 mode 2018-08-21 20:28:06 +00:00
tests/peg [infra] Keep comments intact when updating status files. 2018-04-10 19:03:21 +00:00
application_snapshot.gni [vm] Revert 1db1ac4863. 2019-05-08 23:52:29 +00:00
compile_platform.gni [ VM / Service ] Dynamically load source from linked-in platform kernel 2019-02-21 18:22:39 +00:00
create_timestamp.gni Make list_files.py and list_dart_files.py return absolute paths for GN 2016-12-13 10:01:28 -08:00