mirror of
https://github.com/dart-lang/sdk
synced 2024-10-06 15:19:41 +00:00
fd6fa010ec
NOTES: Original CL: https://dart-review.googlesource.com/c/sdk/+/274061 Revert CL: https://dart-review.googlesource.com/c/sdk/+/274802 Regression tests that failed after merging Original CL: - https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/pkg-mac-release/24046/overview - https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/pkg-mac-release-arm64/5999/overview ---------- DESCRIPTION: Setting the `stream` parameter on `developer.postEvent` will now forward those events to a custom stream inside DDS. The first use of this will be for widget inspection. A navigation event will be posted to a custom stream. Our IDE DAP can listen for the Event and react to it by navigating to the desired location in the code. TEST=Made sure that regression from original PR could be reproduced, and then resolved by applying this change. Updated observatory tests. Created new developer test to check assertions. Added DDS tests for new custom stream behaviour. Manually tested the postEvent and StreamListen with multiple clients https://github.com/flutter/devtools/issues/4533 Change-Id: I2b04a84b4daf11dd9d72f899928b5e1f62a5ae02 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275121 Reviewed-by: Ben Konyi <bkonyi@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com> |
||
|---|---|---|
| .. | ||
| analyzer | ||
| async | ||
| collection | ||
| convert | ||
| developer | ||
| fix_data_tests | ||
| html | ||
| isolate | ||
| js | ||
| math | ||
| mirrors | ||
| typed_data | ||
| web | ||
| lib.status | ||
| lib_analyzer.status | ||
| lib_app_jit.status | ||
| lib_dart2js.status | ||
| lib_dartdevc.status | ||
| lib_kernel.status | ||
| lib_precompiled.status | ||
| lib_vm.status | ||