e86b08e5bb
If a target `_Future` is chained to another source `_Future`, then it's because the target will complete with the same result as the source future. Instead of keeping both alive with a listener on the source which completes the target, instead the target moves all its listeners to be directly on the source, and keeps a link to the source in case more listeners are added later. The idea is that most futures are unreferenced after they have had their first listener, so the target future has a chance to be GC'ed. If the target future has `.ignore()` called, and has no listener, then the source completing with an error should not cause the error to be uncaught. Without the optimization, the source would have had a listener, and the target would ignore the error. To simulate that, the source now gets a copy of the target's `_ignoreUnhandledErrors` flag. This is still not precisely the same as it would be without the optimization. If *two* target futures are chained to the same source, and only one of targes has `.ignore()` called, then this implementation will make the uncaught error not be reported, where it technically should. (An alternative would be to *not* use chaining for futures with `ignore()` called on them. But those are precisely futures that are likely to be GC'able, because someone has already said that they don't care if the future complete with errors.) Fixes #54943 Bug: https://github.com/dart-lang/sdk/issues/54943 Change-Id: I0dbb4919ce2ea612d66539862fa0eb188aab8287 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352908 Reviewed-by: Slava Egorov <vegorov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Lasse Nielsen <lrn@google.com> Reviewed-by: Stephen Adams <sra@google.com> |
||
|---|---|---|
| .dart_tool | ||
| .github | ||
| benchmarks | ||
| build | ||
| docs | ||
| pkg | ||
| runtime | ||
| samples | ||
| sdk | ||
| tests | ||
| third_party | ||
| tools | ||
| utils | ||
| .clang-format | ||
| .gitattributes | ||
| .gitconfig | ||
| .gitignore | ||
| .gn | ||
| .mailmap | ||
| .style.yapf | ||
| AUTHORS | ||
| BUILD.gn | ||
| CHANGELOG.md | ||
| codereview.settings | ||
| CONTRIBUTING.md | ||
| DEPS | ||
| LICENSE | ||
| OWNERS | ||
| PATENT_GRANT | ||
| PRESUBMIT.py | ||
| README.dart-sdk | ||
| README.md | ||
| sdk.code-workspace | ||
| sdk_args.gni | ||
| SECURITY.md | ||
| WATCHLISTS | ||
Dart
An approachable, portable, and productive language for high-quality apps on any platform
Dart is:
-
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
-
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
-
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
-
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
-
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
License & patents
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Using Dart
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
Building Dart
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
Contributing to Dart
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.